Skip to content

Commit 7ae1c4d

Browse files
Remove lastnames feature from MlCitation payload
** Why are these changes being introduced: * We are removing the lastnames feature from the MlCitation detector. It will still be extracted by Detector::Citation, but the algorithm within the detector won't support it. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/tco-155 ** How does this address that need: This filters out the lastnames feature from Detector::MlCitation's extract_features method, which prevents it from being sent to the lambda. The cassettes are also regenerated. Two of them are just removed, which confuses me as they should still be needed. ** Document any side effects to this change: None, as far as I know
1 parent cf35392 commit 7ae1c4d

File tree

6 files changed

+16
-90
lines changed

6 files changed

+16
-90
lines changed

app/models/detector/ml_citation.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ def extract_features(phrase)
133133
features[:apa] = features.delete :apa_volume_issue
134134
features[:year] = features.delete :year_parens
135135
features.delete :characters
136+
features.delete :lastnames
136137
features.sort.to_h
137138
end
138139

test/vcr_cassettes/lambda_citation.yml

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/vcr_cassettes/lambda_citation_all_things.yml

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/vcr_cassettes/lambda_citation_sequence.yml

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/vcr_cassettes/lambda_no_citation.yml

Lines changed: 0 additions & 37 deletions
This file was deleted.

test/vcr_cassettes/lambda_with_wrong_secret.yml

Lines changed: 0 additions & 38 deletions
This file was deleted.

0 commit comments

Comments
 (0)