Add 'book' fields and address some initial code review feedback

Author: jazairi

.env.test

@@ -6,6 +6,7 @@ PRIMO_API_URL=https://api-na.hosted.exlibrisgroup.com/primo/v1
 PRIMO_SCOPE=cdi
 PRIMO_TAB=all
 PRIMO_VID=01MIT_INST:MIT
+SYNDETICS_PRIMO_URL=https://syndetics.com/index.php?client=primo
 TIMDEX_GRAPHQL=https://FAKE_TIMDEX_HOST/graphql
 TIMDEX_HOST=FAKE_TIMDEX_HOST
 TIMDEX_INDEX=FAKE_TIMDEX_INDEX

README.md

@@ -98,6 +98,7 @@ See `Optional Environment Variables` for more information.
 - `PRIMO_SCOPE`: The Primo Search API `scope` param (set to `cdi` for CDI-scoped results).
 - `PRIMO_TAB`: The Primo Search API `tab` param (typically `all`).
 - `PRIMO_VID`: The Primo Search API `vid` (or 'view ID`) param.
+- `SYNDETICS_PRIMO_URL`: The Syndetics API URL for Primo. This is used to construct thumbnail URLs.
 - `TIMDEX_GRAPHQL`: Set this to the URL of the GraphQL endpoint. There is no default value in the application.
 
 ### Optional Environment Variables

app/models/normalize_primo.rb

@@ -1,7 +1,8 @@
 # Transforms results from Primo Search API into normalized records
 class NormalizePrimo
-  def initialize(record)
+  def initialize(record, query)
     @record = record
+    @query = query
   end
 
   def normalize
@@ -17,7 +18,13 @@ def normalize
       'identifier' => record_id,
       'summary' => summary,
       'numbering' => numbering,
-      'chapter_numbering' => chapter_numbering
+      'chapter_numbering' => chapter_numbering,
+      'thumbnail' => thumbnail,
+      'publisher' => publisher,
+      'location' => best_location,
+      'subjects' => subjects,
+      'availability' => best_availability,
+      'other_availability' => other_availability?
     }
   end
 
@@ -78,8 +85,10 @@ def format
   def links
     links = []
 
-    # Add direct record link as the first link
-    if record_link.present?
+    # Use dedup URL as the full record link if available, otherwise use record link
+    if dedup_url.present?
+      links << { 'url' => dedup_url, 'kind' => 'full record' }
+    elsif record_link.present?
       links << { 'url' => record_link, 'kind' => 'full record' }
     end
 
@@ -176,12 +185,6 @@ def chapter_numbering
     "#{@record['pnx']['addata']['date'].join}, pp. #{@record['pnx']['addata']['pages'].join}"
   end
 
-  def openurl
-    return unless @record['delivery'] && @record['delivery']['almaOpenurl']
-
-    @record['delivery']['almaOpenurl'].is_a?(Array) ? @record['delivery']['almaOpenurl'].join : @record['delivery']['almaOpenurl']
-  end
-
   def sanitize_authors(authors)
     authors.map! { |author| author.split(';') }.flatten! if authors.any? { |author| author.include?(';') }
     authors.map { |author| author.strip.gsub(/\$\$Q.*$/, '') }
@@ -246,4 +249,68 @@ def construct_primo_openurl
     filtered = params.delete_if { |key, _value| key.starts_with?('ctx') }
     URI::DEFAULT_PARSER.unescape(filtered.to_param)
   end
+
+  def thumbnail
+    return unless @record['pnx']['addata'] && @record['pnx']['addata']['isbn']
+
+    # A record can have multiple ISBNs, so we are assuming here that
+    # the thumbnail URL can be constructed from the first occurrence
+    isbn = @record['pnx']['addata']['isbn'].first
+    [ENV['SYNDETICS_PRIMO_URL'], '&isbn=', isbn, '/sc.jpg'].join
+  end
+
+  def publisher
+    return unless @record['pnx']['addata'] && @record['pnx']['addata']['pub']
+    @record['pnx']['addata']['pub'].first
+  end
+
+  def best_location
+    return unless @record['delivery']
+    return unless @record['delivery']['bestlocation']
+    loc = @record['delivery']['bestlocation']
+    ["#{loc['mainLocation']} #{loc['subLocation']}", loc['callNumber']]
+  end
+
+  def subjects
+    return [] unless @record['pnx']['display']['subject']
+    @record['pnx']['display']['subject']
+  end
+
+  def best_availability
+    return unless best_location
+    @record['delivery']['bestlocation']['availabilityStatus']
+  end
+
+  def other_availability?
+    return unless @record['delivery']['bestlocation']
+    return unless @record['delivery']['holding']
+    @record['delivery']['holding'].length > 1
+  end
+
+  # FRBR Group check based on:
+  # https://knowledge.exlibrisgroup.com/Primo/Knowledge_Articles/Primo_Search_API_-_how_to_get_FRBR_Group_members_after_a_search
+  def frbrized?
+    return unless @record['pnx']['facets']
+    return unless @record['pnx']['facets']['frbrtype']
+    @record['pnx']['facets']['frbrtype'].join == '5'
+  end
+
+  def dedup_url
+    return unless frbrized?
+    return unless @record['pnx']['facets']['frbrgroupid'] &&
+                  @record['pnx']['facets']['frbrgroupid'].length == 1
+    
+    frbr_group_id = @record['pnx']['facets']['frbrgroupid'].join
+    base = [ENV['MIT_PRIMO_URL'], '/discovery/search?'].join
+    
+    query = {
+      query: "any,contains,#{@query}",
+      tab: ENV['PRIMO_TAB'],
+      search_scope: ENV['PRIMO_SCOPE'],
+      sortby: 'date_d',
+      vid: ENV['PRIMO_VID'],
+      facet: "frbrgroupid,include,#{frbr_group_id}"
+    }.to_query
+    [base, query].join
+  end
 end

app/models/primo_search.rb

@@ -14,17 +14,12 @@ def initialize
 
   def search(term, per_page)
     url = search_url(term, per_page)
-    Rails.logger.info "Primo Search URL: #{url}"
-    
     result = @primo_http.timeout(http_timeout)
                       .headers(
                         accept: 'application/json',
                         Authorization: "apikey #{PRIMO_API_KEY}"
                       )
                       .get(url)
-
-    Rails.logger.info "Primo Response Status: #{result.status}"
-    Rails.logger.info "Primo Response Headers: #{result.headers.to_h}"
 
     raise "Primo Error Detected: #{result.status}" unless result.status == 200
 

test/fixtures/primo/full_record.json

@@ -15,7 +15,13 @@
       "volume": ["2"],
       "issue": ["3"],
       "pages": ["123-145"],
-      "jtitle": ["Journal of Testing"]
+      "jtitle": ["Journal of Testing"],
+      "isbn": ["9781234567890", "1234567890"],
+      "pub": ["MIT Press"]
+    },
+    "facets": {
+      "frbrtype": ["5"],
+      "frbrgroupid": ["12345"]
     },
     "search": {
       "creationdate": ["2023"]
@@ -29,9 +35,14 @@
     "bestlocation": {
       "mainLocation": "Hayden Library",
       "subLocation": "Stacks",
-      "callNumber": "QA76.73.R83 2023"
+      "callNumber": "QA76.73.R83 2023",
+      "availabilityStatus": "available"
     },
+    "holding": [
+      {"location": "Main Library"},
+      {"location": "Branch Library"}
+    ],
     "link": [],
-    "almaOpenurl": "https://example.com/openurl?param=value"
+    "almaOpenurl": "https://na06.alma.exlibrisgroup.com/view/uresolver/01MIT_INST/openurl?param=value"
   }
 }