Address code review feedback

Author: jazairi

app/controllers/search_controller.rb

@@ -43,7 +43,7 @@ def results
   def load_gdt_results
     query = QueryBuilder.new(@enhanced_query).query
 
-    response = cache_timdex_query(query)
+    response = query_timdex(query)
 
     # Handle errors
     @errors = extract_errors(response)
@@ -53,7 +53,7 @@ def load_gdt_results
   end
 
   def load_primo_results
-    primo_response = cache_primo_query
+    primo_response = query_primo
     @results = NormalizePrimoResults.new(primo_response, @enhanced_query[:q]).normalize
 
     # Enhanced pagination using cached response
@@ -74,7 +74,7 @@ def load_primo_results
 
   def load_timdex_results
     query = QueryBuilder.new(@enhanced_query).query
-    response = cache_timdex_query(query)
+    response = query_timdex(query)
 
     @errors = extract_errors(response)
     @pagination = Analyzer.new(@enhanced_query, response).pagination if @errors.nil?
@@ -85,25 +85,29 @@ def active_filters
     ENV.fetch('ACTIVE_FILTERS', '').split(',').map(&:strip)
   end
 
-  def cache_timdex_query(query)
+  def query_timdex(query)
+    # We generate unique cache keys to avoid naming collisions.
     cache_key = generate_cache_key(query)
 
-    # builder hands off to wrapper which returns raw results here
-    # The response type is a GraphQL::Client::Response, which is not directly serializable, so we convert it to a hash.
+    # Builder hands off to wrapper which returns raw results here.
     Rails.cache.fetch("#{cache_key}/#{@active_tab}", expires_in: 12.hours) do
       raw = if @active_tab == 'gdt'
               execute_geospatial_query(query)
             elsif @active_tab == 'timdex'
               TimdexBase::Client.query(TimdexSearch::BaseQuery, variables: query)
             end
+
+      # The response type is a GraphQL::Client::Response, which is not directly serializable, so we
+      # convert it to a hash.
       {
         data: raw.data.to_h,
         errors: raw.errors.details.to_h
       }
     end
   end
 
-  def cache_primo_query
+  def query_primo
+    # We generate unique cache keys to avoid naming collisions.
     cache_key = generate_cache_key(@enhanced_query)
 
     Rails.cache.fetch("#{cache_key}/primo", expires_in: 12.hours) do
@@ -113,10 +117,6 @@ def cache_primo_query
     end
   end
 
-  # We are using two difference caches to allow for Geo and USE to be cached separately. This ensures we don't have
-  # cache key collision for these two different query types. In practice, the likelihood of this happening is low,
-  # as the query parameters are different for each type and they won't often be run with the same cache backend other
-  # than locally, but this is a safeguard.
   def generate_cache_key(query)
     # Sorting query hash to ensure consistent key generation regardless of the parameter order
     sorted_query = query.sort_by { |k, _v| k.to_sym }.to_h