Merge pull request #158 from MITLibraries/filter-bugfix

Render filter value names in non-GDT contexts

Author: jazairi

app/views/search/_filter.html.erb

@@ -15,9 +15,11 @@
           <a href="<%= results_path(add_filter(@enhanced_query, category, term['key'])) %>">
           <span class="sr">Apply filter:</span>
         <% end %>
-          <% if Flipflop.enabled?(:gdt) %>
-            <span class="name"><%= gdt_sources(term['key'], category) %></span>
-          <% end %>
+        <% if Flipflop.enabled?(:gdt) %>
+          <span class="name"><%= gdt_sources(term['key'], category) %></span>
+        <% else %>
+          <span class="name"><%= term['key'] %></span>
+        <% end %>
           <span class="count"><%= term['docCount'] %> <span class="sr">records</span></span>
         </a>
       </li>

test/controllers/search_controller_test.rb

@@ -139,6 +139,17 @@ class SearchControllerTest < ActionDispatch::IntegrationTest
     end
   end
 
+  test 'a filter category lists available filters with names and values' do
+    VCR.use_cassette('data basic controller',
+                     allow_playback_repeats: true,
+                     match_requests_on: %i[method uri body]) do
+      get '/results?q=data'
+      assert_response :success
+      assert_select '.filter-options .category-terms .name', { minimum: 1 }
+      assert_select '.filter-options .category-terms .count', { minimum: 1 }
+    end
+  end
+
   test 'results with valid query has div for pagination' do
     VCR.use_cassette('data basic controller',
                      allow_playback_repeats: true,