Handle some edge cases

- bbox is sometimes in a different field (ticket opened to understand why)
- bbox sometimes has spaces and sometimes not so we handle both
- convert strings to floats during initial string extraction rather than during coords array creation
- if bbox_array is not 4 elements, don't use it
- if we don't have a record at all, don't try to use it

Author: JPrevost

app/controllers/record_controller.rb

@@ -21,13 +21,34 @@ def view
 
   private
 
+  # Converts a bounding box into a top left, bottom right set of coordinates
   def bounding_box_to_coords
+    return unless @record.present?
     return unless geospatial_coordinates?(@record['locations'])
 
+    # Our preference is to use the `Bounding Box` kind
     raw_bbox = @record['locations'].select { |l| l if l['kind'] == 'Bounding Box' }.first
+
+    # If we had no `Bounding Box` kind, see if we have a `Geometry kind`
+    if raw_bbox.blank?
+      raw_bbox = @record['locations'].select { |l| l if l['kind'] == 'Geometry' }.first
+    end
+
+    return unless raw_bbox.present?
+
+    # extract just the geo coordinates and remove the extra syntax
     bbox = raw_bbox['geoshape'].sub('BBOX (', '').sub(')', '')
-    bbox_array = bbox.split(', ')
-    coords = [[bbox_array[2].to_f, bbox_array[0].to_f], [bbox_array[3].to_f, bbox_array[1].to_f]]
+
+    # conver the string into an array of floats
+    bbox_array = bbox.split(',').map!(&:strip).map!(&:to_f)
+
+    # Protect against unexpected data
+    if bbox_array.count != 4
+      Rails.logger.info("Unexpected Bounding Box: #{raw_bbox}")
+      return
+    end
+
+    coords = [[bbox_array[2], bbox_array[0]], [bbox_array[3], bbox_array[1]]]
     Rails.logger.info("Raw BBox: #{raw_bbox}")
     Rails.logger.info("Rectangle: #{coords}")
     coords