Handle URLs that may already have query params

A few complex lines were moved to their own methods to make reading the method a bit easier

Author: JPrevost

Gemfile.lock

@@ -361,6 +361,7 @@ GEM
 
 PLATFORMS
   arm64-darwin-22
+  arm64-darwin-23
   x86_64-darwin-19
   x86_64-darwin-20
   x86_64-darwin-21

app/helpers/record_helper.rb

@@ -84,13 +84,27 @@ def gis_access_link(metadata)
     # At this point, we don't show download links for non-MIT records. For MIT records, the download link is stored
     # consistently as a download link. We are confirming that the link text is 'Data' for added confirmation.
     if access_type(metadata) == 'unknown: check with owning institution'
-      links.select { |link| link['kind'] == 'Website' }.first['url']
+      website_url(links)
     else
-      url = links.select { |link| link['kind'] == 'Download' && link['text'] == 'Data' }.first['url']
-      "#{url}?timdexui=true"
+      url = download_url(links)
+      append_timdexui(url)
     end
   end
 
+  def website_url(links)
+    links.select { |link| link['kind'] == 'Website' }.first['url']
+  end
+
+  def download_url(links)
+    links.select { |link| link['kind'] == 'Download' && link['text'] == 'Data' }.first['url']
+  end
+
+  def append_timdexui(url)
+    uri = Addressable::URI.parse(url)
+    uri.query_values = (uri.query_values || {}).merge(timdexui: true)
+    uri.to_s
+  end
+
   def access_type(metadata)
     access_right = metadata['rights']&.select { |right| right['kind'] == 'Access to files' }
     return if access_right.blank?

test/helpers/record_helper_test.rb

@@ -247,6 +247,18 @@ class RecordHelperTest < ActionView::TestCase
     assert_equal 'https://example.org/dz_f7regions_2016.zip?timdexui=true', gis_access_link(access_auth)
   end
 
+  test 'append_timdexui_with_no_existing_query_values' do
+    url = 'https://example.org/dz_f7regions_2016.zip'
+    assert_equal('https://example.org/dz_f7regions_2016.zip?timdexui=true',
+                 append_timdexui(url))
+  end
+
+  test 'append_timdexui_with_existing_query_values' do
+    url = 'https://example.org/dz_f7regions_2016.zip?hallo=goodbye'
+    assert_equal('https://example.org/dz_f7regions_2016.zip?hallo=goodbye&timdexui=true',
+                 append_timdexui(url))
+  end
+
   test 'source_metadata_available? returns true if source metadata link exists' do
     links = [{ 'kind' => 'Download', 'text' => 'Source Metadata', 'url' => 'https://example.org/metadata.zip' }]
     assert source_metadata_available?(links)