Commit 8120e84
committed
Support full records without pub_date or id
Why are these changes being introduced:
* Some records don't have publication date information (which is
expected)
Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/TIMX-108
How does this address that need:
* Adds nil protection for publication dates
Document any side effects to this change:
* After handling the publication date nil, an error occurred for
identifier not being present. I believe this is unexpected and is a
result of incomplete Alma mappings in dev1 at this time. Handling nils
for identifers seemed fine to include even if the data will likely
all include at least one identifier per record.1 parent 3e87c87 commit 8120e84
File tree
4 files changed
+87
-2
lines changed- app
- helpers
- views/record
- test
- integration
- vcr_cassettes
4 files changed
+87
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
18 | 29 | | |
Lines changed: 74 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments