Update link_to_tab variable names and add tests

Author: JPrevost

app/helpers/search_helper.rb

@@ -28,14 +28,14 @@ def link_to_result(result)
   # @return [String] HTML link element for the tab
   def link_to_tab(target, label = nil)
     clean_target = target.downcase.gsub(' ', '_').downcase
-    target = label || target
+    tab_label = label || target
     if @active_tab == clean_target
-      link_to target, results_path(params.permit(:q, :per_page, :booleanType, :tab).merge(tab: clean_target)),
+      link_to tab_label, results_path(params.permit(:q, :per_page, :booleanType, :tab).merge(tab: clean_target)),
               aria: { current: 'page' },
               class: 'active tab-link',
               data: { turbo_frame: 'search-results', turbo_action: 'advance' }
     else
-      link_to target, results_path(params.permit(:q, :per_page, :booleanType, :tab).merge(tab: clean_target)),
+      link_to tab_label, results_path(params.permit(:q, :per_page, :booleanType, :tab).merge(tab: clean_target)),
               class: 'tab-link',
               data: { turbo_frame: 'search-results', turbo_action: 'advance' }
     end

test/helpers/search_helper_test.rb

@@ -203,7 +203,7 @@ class SearchHelperTest < ActionView::TestCase
     @active_tab = 'bar'
     actual = link_to_tab('Foo')
 
-    assert_select Nokogiri::HTML::Document.parse( actual ), 'a' do |link|
+    assert_select Nokogiri::HTML::Document.parse(actual), 'a' do |link|
       assert_select '[class*=?]', 'active', count: 0
       assert_select '[class*=?]', 'tab-link'
       assert_select '[aria-current=?]', 'page', count: 0
@@ -214,7 +214,7 @@ class SearchHelperTest < ActionView::TestCase
     @active_tab = 'foo'
     actual = link_to_tab('Foo')
 
-    assert_select Nokogiri::HTML::Document.parse( actual ), 'a' do |link|
+    assert_select Nokogiri::HTML::Document.parse(actual), 'a' do |link|
       assert_select link, '[class*=?]', 'active'
       assert_select link, '[aria-current=?]', 'page', count: 1
     end
@@ -231,4 +231,36 @@ class SearchHelperTest < ActionView::TestCase
     expected_url = 'https://mit.primo.exlibrisgroup.com/discovery/search?query=any%2Ccontains%2Cdata+%26+analytics&vid=01MIT_INST%3AMIT'
     assert_equal expected_url, primo_search_url(query)
   end
+
+  test 'tab label defaults to target when label is nil' do
+    @active_tab = 'sample_tab'
+    actual = link_to_tab('Sample Tab', nil)
+    assert_select Nokogiri::HTML::Document.parse(actual), 'a' do |link|
+      assert_equal link.text, 'Sample Tab'
+    end
+  end
+
+  test 'tab label uses label when label is provided' do
+    @active_tab = 'sample_tab'
+    actual = link_to_tab('Sample Tab', 'Custom Label')
+    assert_select Nokogiri::HTML::Document.parse(actual), 'a' do |link|
+      assert_equal link.text, 'Custom Label'
+    end
+  end
+
+  test 'tab param uses clean_target when label is nil' do
+    @active_tab = 'sample_tab'
+    actual = link_to_tab('Sample Tab', nil)
+    assert_select Nokogiri::HTML::Document.parse(actual), 'a' do |link|
+      assert_equal link.first[:href], '/results?tab=sample_tab'
+    end
+  end
+
+  test 'tab param uses clean_target when label is provided' do
+    @active_tab = 'sample_tab'
+    actual = link_to_tab('Sample Tab', 'Custom Label')
+    assert_select Nokogiri::HTML::Document.parse(actual), 'a' do |link|
+      assert_equal link.first[:href], '/results?tab=sample_tab'
+    end
+  end
 end