Tweak to application helper, with test

Author: matt-bernhardt

app/helpers/application_helper.rb

@@ -1,6 +1,6 @@
 module ApplicationHelper
   def tacos_enabled?
-    ENV.fetch('TACOS_URL', false)
+    ENV.fetch('TACOS_URL', '').length > 0
   end
   module_function :tacos_enabled?
 

test/helpers/application_helper_test.rb

@@ -3,6 +3,16 @@
 class ApplicationHelperTest < ActionView::TestCase
   include ApplicationHelper
 
+  test 'tacos_enabled? requires TACOS_URL env variable to have non-zero length' do
+    ClimateControl.modify TACOS_URL: 'foo' do
+      assert_equal true, tacos_enabled?
+    end
+
+    ClimateControl.modify TACOS_URL: '' do
+      assert_equal false, tacos_enabled?
+    end
+  end
+
   test 'index_page_title renders as expected' do
     assert_equal 'Search | MIT Libraries', index_page_title
   end