Remove tab logic (these will be full page loads)

Author: jazairi

app/assets/stylesheets/partials/_loading_spinner.scss

@@ -1,12 +1,13 @@
-// Loading indicator for Turbo Frame updates
+// Loading indicator for pagination (Turbo Frame updates)
+// Tab navigation uses full page loads with Turbo's built-in progress bar
 // https://discuss.hotwired.dev/t/show-spinner-everytime-async-frame-reloads/3483/3
 @keyframes spinner {
   to { 
     transform: rotate(360deg); 
   }
 }
 
-// Results overlay when loading
+// Pagination overlay when loading
 [busy]:not([no-spinner]) {
   position: relative;
   min-height: 400px;

app/javascript/loading_spinner.js

@@ -1,26 +1,10 @@
-// Loading spinner behavior for search results
+// Loading spinner behavior for pagination (Turbo Frame updates)
 document.addEventListener('turbo:frame-render', function(event) {
-  // Remove loading state from tabs when frame finishes loading
-  const tabs = document.querySelector('.tab-navigation');
-  if (tabs) {
-    tabs.classList.remove('loading');
-  }
-  
-  // Focus management after content loads
-  if (window.pendingFocusAction) {
-    if (window.pendingFocusAction === 'pagination') {
-      // Focus on first result for pagination
-      const firstResult = document.querySelector('.results-list .result h3 a, .results-list .result .record-title a');
-      if (firstResult) {
-        firstResult.focus();
-      }
-    } else if (window.pendingFocusAction === 'tab-switch') {
-      // Focus on results summary for tab switches
-      const resultsContext = document.querySelector('.results-context');
-      if (resultsContext) {
-        resultsContext.setAttribute('tabindex', '-1');
-        resultsContext.focus();
-      }
+  if (window.pendingFocusAction === 'pagination') {
+    // Focus on first result for pagination
+    const firstResult = document.querySelector('.results-list .result h3 a, .results-list .result .record-title a');
+    if (firstResult) {
+      firstResult.focus();
     }
     // Clear the pending action
     window.pendingFocusAction = null;
@@ -30,22 +14,9 @@ document.addEventListener('turbo:frame-render', function(event) {
 document.addEventListener('click', function(event) {
   const clickedElement = event.target;
 
-  // Handle pagination clicks (scroll to top and set pending focus action)
-  if (clickedElement.matches('.tab-link')) {
-    const tabs = document.querySelector('.tab-navigation');
-    if (tabs) {
-      tabs.classList.add('loading');
-    }
-    window.pendingFocusAction = 'tab-switch';
-  }
-
-  // Handle pagination clicks (scroll to top and set pending focus action)
+  // Handle pagination clicks
   if (clickedElement.closest('.pagination-container') || 
       clickedElement.matches('.first a, .previous a, .next a')) {
-    const tabs = document.querySelector('.tab-navigation');
-    if (tabs) {
-      tabs.classList.add('loading');
-    }
     window.scrollTo({ top: 0, behavior: 'smooth' });
     window.pendingFocusAction = 'pagination';
   }