Address code review feedback

Author: jazairi

app/models/normalize_timdex_record.rb

@@ -15,7 +15,7 @@ def normalize
       'format' => format,
       'links' => links,
       'citation' => citation,
-      'identifier' => record_id,
+      'identifier' => identifier,
       'summary' => summary,
       'publisher' => publisher,
       'location' => location,
@@ -45,7 +45,9 @@ def creators
   end
 
   def source
-    @record['source']&.first || 'Unknown source'
+    return 'Unknown source' unless @record['source']
+
+    @record['source']
   end
 
   def year
@@ -113,7 +115,7 @@ def subjects
     @record['subjects'].map { |subject| subject['value'] }
   end
 
-  def record_id
+  def identifier
     @record['timdexRecordId']
   end
 

app/views/search/_result_geo.html.erb

@@ -1,19 +1,12 @@
 <li class="result">
   <div class="result-content">
     <h3 class="record-title">
-      <span class="sr">Title: </span><%= link_to(result_geo['title'], record_path(result_geo['timdex_record_id'])) %>
+      <span class="sr">Title: </span><%= link_to(result_geo['title'], record_path(result_geo['identifier'])) %>
     </h3>
 
-    <% if result_geo['content_type'] || result_geo['dates'] %>
-      <div class="data-info">
-        <%= render partial: 'shared/geo_data_info', locals: { 
-          metadata: { 
-            'contentType' => result_geo['content_type'], 
-            'dates' => result_geo['dates'] 
-          } 
-        } %>
-      </div>
-    <% end %>
+    <div class="data-info">
+      <%= render partial: 'shared/geo_data_info', locals: { metadata: result_geo } %>
+    </div>
 
     <% if result_geo['creators'].present? || result_geo['contributors'].present? %>
       <span class="sr">Contributors: </span>
@@ -39,7 +32,7 @@
     <% end %>
 
     <div class="result-record">
-      <%= view_record(result_geo['timdex_record_id']) %>
+      <%= view_record(result_geo['identifier']) %>
     </div>
   </div>
 </li>

app/views/shared/_geo_data_info.html.erb

@@ -11,4 +11,4 @@
   <% elsif access_type(metadata) == 'MIT authentication required' %>
     <li><span class="access-restricted"><%= access_type(metadata) %></span></li>
   <% end %>
-</ul>
+</ul>

test/fixtures/timdex/full_record.json

@@ -1,7 +1,7 @@
 {
   "timdexRecordId": "test-record-123",
   "title": "Sample TIMDEX Record for Testing",
-  "source": ["Test Repository"],
+  "source": "Test Repository",
   "contentType": [
     {"value": "Dataset"},
     {"value": "Geospatial data"}

test/fixtures/timdex/minimal_record.json

@@ -1,5 +1,5 @@
 {
   "timdexRecordId": "minimal-record-456",
   "title": "Minimal Test Record",
-  "source": ["Test Repository"]
+  "source": "Test Repository"
 }