Skip to content

Adds crawler directives to result and record pages #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

Adds crawler directives to result and record pages #206

merged 1 commit into from
Feb 28, 2025

Conversation

@JPrevost
Copy link
Member

@JPrevost JPrevost commented Feb 28, 2025

Why are these changes being introduced:

  • It doesn't make sense to have search engines index and follow links from our own results and record pages

Relevant ticket(s):

How does this address that need:

  • adds meta robots tag with noindex, nofollow rules

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@JPrevost
Adds crawler directives to result and record pages
9da3cbc 
Why are these changes being introduced:

* It doesn't make sense to have search engines index and follow links
  from our own results and record pages

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/TIMX-476

How does this address that need:

* adds meta robots tag with noindex, nofollow rules
@mitlib mitlib temporarily deployed to timdex-ui-pi-timx-476-n-avzb8w February 28, 2025 19:54 Inactive
@coveralls
Copy link

coveralls commented Feb 28, 2025

Pull Request Test Coverage Report for Build 13595485878

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 98.485%
Files with Coverage Reduction New Missed Lines %
app/controllers/search_controller.rb 1 98.11%
Totals Coverage Status
Change from base Build 13445056239: -0.2%
Covered Lines: 585
Relevant Lines: 594
💛 - Coveralls

@jazairi jazairi self-assigned this Feb 28, 2025
@JPrevost JPrevost merged commit 8ea55ed into main Feb 28, 2025
5 checks passed
@JPrevost JPrevost deleted the timx-476-noindex-nofollow branch February 28, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jazairi jazairi jazairi approved these changes

@matt-bernhardt matt-bernhardt Awaiting requested review from matt-bernhardt

Assignees

@jazairi jazairi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JPrevost @coveralls @jazairi @mitlib