-
Notifications
You must be signed in to change notification settings - Fork 0
CloudFlare Turnstile #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudFlare Turnstile #208
Conversation
Why are these changes being introduced: * Bots are using more resources than desired Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-480 How does this address that need: * Adds rack-attack and bot_challenge_page gems * Adds redis to heroku app.json (will need to manually enable in staging and production environments before merge)
Pull Request Test Coverage Report for Build 14038084987Details
💛 - Coveralls |
55068b5 to
c69842e
Compare
jazairi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this works as described locally. (I.e., after 10 requests to /results, I get a 403 page.) I've never configured these tools before, so I can't offer much on that side of things, but the config seems straightforward enough.
As I understand it, the only risk introduced here is that a user will get a Cloudflare turnstile every 10 search attempts. That might be a little onerous for folks on an extended user journey, but since we can easily adjust it, I think it's fine as an initial setting.
|
@jazairi Just to clarify, once a user gets a turnstile challenge and passes they will not get another challenge in that browser instance for about a day regardless of how many searches they do. |
|
@JPrevost In that case, no concerns on my end. |
Why are these changes being introduced:
Relevant ticket(s):
How does this address that need:
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing