Skip to content

Conversation

@JPrevost
Copy link
Member

@JPrevost JPrevost commented Nov 21, 2025

Why are these changes being introduced:

  • Initial implementation only had placeholder text for the eyebrow
    above the title in search results.
  • Dynamic eyebrow support for Timdex and Primo records was requested.

Relevant ticket(s):

How does this address that need:

  • Adds eyebrow to Timdex and Primo record normalization.
  • Updates search result partials to display eyebrow if present.

Document any side effects to this change:

  • These are unlikely to be the final values for the eyebrows, but they
    provide a starting point for further refinement based on feedback.
  • We were not requesting source from TIMDEX API. Adding it required a lot of cassette updates. I didn't regenerate the cassettes and only changed the query they contain to include the source. Regenerating cassettes might be better, but I decided to defer that debt to the future.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

Why are these changes being introduced:

* Initial implementation only had placeholder text for the eyebrow
  above the title in search results.
* Dynamic eyebrow support for Timdex and Primo records was requested.

Relevant ticket(s):

* https://mitlibraries.atlassian.net/browse/USE-221

How does this address that need:

* Adds eyebrow to Timdex and Primo record normalization.
* Updates search result partials to display eyebrow if present.

Document any side effects to this change:

* These are unlikely to be the final values for the eyebrows, but they
  provide a starting point for further refinement based on feedback.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19581081419

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 97.833%

Totals Coverage Status
Change from base Build 19577531329: 0.01%
Covered Lines: 948
Relevant Lines: 969

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-221-dy-7re8re November 21, 2025 19:21 Inactive
@matt-bernhardt matt-bernhardt self-assigned this Nov 21, 2025
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty straightforward to me. I'm not sure what the ultimate configuration will look like after we have messy values to deal with, but the two methods in the normalizers are really straightforward.

:shipit:

@JPrevost JPrevost merged commit dce4238 into main Nov 21, 2025
5 checks passed
@JPrevost JPrevost deleted the use-221-dynamic-eyebrows branch November 21, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants