Skip to content

Implemented icons in sidebar and callouts in results list #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
Merged

Implemented icons in sidebar and callouts in results list #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion app/assets/stylesheets/partials/_results.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,16 @@
flex-direction: column;
gap: 32px;

> div {
display: flex;
gap: 12px;

i {
font-size: 2rem;
margin-top: 1px;
}
}

@media (max-width: 1140px) {
flex-basis: 280px;
}
Expand Down Expand Up @@ -341,8 +351,15 @@

aside {
border: 3px solid $color-border-default;
padding: 20px 24px;
padding: 20px 24px;
display: flex;
gap: 12px;

i {
font-size: 2rem;
margin-top: 1px;
}

p {
line-height: 1.4;
}
Expand Down
1 change: 1 addition & 0 deletions app/views/layouts/_head.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<![endif]-->
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/normalize/4.1.1/normalize.min.css">
<%= stylesheet_link_tag 'https://use.typekit.net/ixd2vgq.css' %>
<%= stylesheet_link_tag 'https://cdn.libraries.mit.edu/files/fontawesome/7.1.0/css/all.min.css' %>
Copy link
Member

@matt-bernhardt matt-bernhardt Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray for using the CDN as much as we can :-)

<%= stylesheet_link_tag 'application', media: 'all', 'data-turbo-track': 'reload' %>

<!-- For all other devices -->
Expand Down
2 changes: 0 additions & 2 deletions app/views/layouts/application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
</div>
</div>

<script src="https://use.fontawesome.com/38304317ff.js"></script>

<footer>
<%= render partial: "layouts/libraries_footer" %>
<%= render partial: "layouts/institute_footer" %>
Expand Down
4 changes: 2 additions & 2 deletions app/views/search/_results_callouts.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<div id="callout-wrapper">
<aside class="result-callout">
<i></i>
<i class="fa-light fa-magnifying-glass"></i>
<div>
<h4>Refine your search</h4>
<p>Use advanced search features to expand or filter your search.</p>
<a href="#">Search Primo</a>
</div>
</aside>
<aside class="result-callout">
<i></i>
<i class="fa-light fa-book"></i>
<div>
<h4>Can’t find a book?</h4>
<p>If we don’t own it you can often request it from another library.</p>
Expand Down
4 changes: 2 additions & 2 deletions app/views/search/_results_sidebar.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<aside id="results-sidebar">
<div>
<i></i>
<i class="fa-light fa-message"></i>
<div>
<h4>Were these results useful?</h4>
<p>Your feedback can help shape the quality and relevance of our search results.</p>
<a href="#">Send feedback</a>
</div>
</div>
<div>
<i></i>
<i class="fa-light fa-user"></i>
<div>
<h4>Get help from expert librarians</h4>
<p>From thesis research to course reserves, we can help you find what you need.</p>
Expand Down