Skip to content

Commit 3f80f18

Browse files
refactor naming for extension ids (#46)
1 parent d8df886 commit 3f80f18

File tree

3 files changed

+19
-38
lines changed

3 files changed

+19
-38
lines changed

README.md

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,21 +29,19 @@ Rather than having a separate Kanban board for collaborating on projects separat
2929
- Rollup
3030
- GitHub API (Apollo GraphQL)
3131

32-
## Icon source
33-
- [Codicons](https://microsoft.github.io/vscode-codicons/dist/codicon.html)
34-
3532
## Contributors
3633

37-
- [Samuel Yuan] (https://github.com/yuansamuel)
38-
- [Shrill Shrestha] (https://github.com/shrillshrestha)
39-
- [Aitik Gupta] (https://github.com/aitikgupta)
40-
- [Dean Gladish] (https://github.com/gladishd)
34+
- [Samuel Yuan](https://github.com/yuansamuel)
35+
- [Shrill Shrestha](https://github.com/shrillshrestha)
36+
- [Aitik Gupta](https://github.com/aitikgupta)
37+
- [Dean Gladish](https://github.com/gladishd)
4138

4239
## How to run locally?
43-
- git clone https://github.com/Open-Sourced-Olaf/vscode-github-projects.git
44-
- npm install
45-
- npm run watch
46-
- code .
40+
- `git` clone https://github.com/Open-Sourced-Olaf/vscode-github-projects.git
41+
- `cd` into the project folder
42+
- `code .`
43+
- `npm install`
44+
- `npm run webpack`
4745
- fn + F5 (or Launch Extension in command palette)
4846
- Don't forget to sign in with GitHub!
4947

package.json

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,26 +10,25 @@
1010
"Other"
1111
],
1212
"activationEvents": [
13-
"onView:proj-sidebar",
14-
"onCommand:vscode-github-projects.helloWorld",
15-
"onCommand:vscode-github-projects.showWarningMessage"
13+
"onView:vsc-github-projects",
14+
"onCommand:vscode-github-projects.revelProjects"
1615
],
1716
"main": "./dist/extension",
1817
"contributes": {
1918
"viewsContainers": {
2019
"activitybar": [
2120
{
22-
"id": "proj-sidebar-view",
21+
"id": "vsc-github-projects-view",
2322
"title": "VS-GitHub-Projects",
2423
"icon": "media/project.svg"
2524
}
2625
]
2726
},
2827
"views": {
29-
"proj-sidebar-view": [
28+
"vsc-github-projects-view": [
3029
{
3130
"type": "webview",
32-
"id": "proj-sidebar",
31+
"id": "vsc-github-projects",
3332
"name": "VS-GitHub-Projects",
3433
"icon": "media/project.svg",
3534
"contextualTitle": "VS-GitHub-Projects"
@@ -38,12 +37,9 @@
3837
},
3938
"commands": [
4039
{
41-
"command": "vscode-github-projects.helloWorld",
42-
"title": "Hello World"
43-
},
44-
{
45-
"command": "vscode-github-projects.showWarningMessage",
46-
"title": "Show Warning Message"
40+
"command": "vscode-github-projects.revelProjects",
41+
"title": "Revel Projects",
42+
"category": "VSCODE-GITHUB-PROJECTS"
4743
}
4844
]
4945
},

src/extension.ts

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,29 +10,16 @@ export function activate(context: vscode.ExtensionContext) {
1010
const sidebarProvider = new SidebarProvider(context.extensionUri, context);
1111
context.subscriptions.push(
1212
vscode.window.registerWebviewViewProvider(
13-
"proj-sidebar",
13+
"vsc-github-projects",
1414
sidebarProvider
1515
)
1616
);
1717

18-
// Use the console to output diagnostic information (console.log) and errors (console.error)
19-
// This line of code will only be executed once when your extension is activated
20-
console.log('Congratulations, your extension "vscode-github-projects" is now active!');
21-
22-
// The command has been defined in the package.json file
23-
// Now provide the implementation of the command with registerCommand
24-
// The commandId parameter must match the command field in package.json
25-
context.subscriptions.push(vscode.commands.registerCommand('vscode-github-projects.helloWorld', () => {
18+
context.subscriptions.push(vscode.commands.registerCommand('vscode-github-projects.revelProjects', () => {
2619
// The code you place here will be executed every time your command is executed
2720
HomePanel.createOrShow(context.extensionUri, {});
2821
})
2922
);
30-
31-
context.subscriptions.push(vscode.commands.registerCommand('vscode-github-projects.showWarningMessage', () => {
32-
//warning message
33-
vscode.window.showWarningMessage("Hey, here's a sample warning message");
34-
})
35-
);
3623
}
3724

3825
// this method is called when your extension is deactivated

0 commit comments

Comments
 (0)