[DEV-2349] add custom httpstatus cop here instead (#3)

* add custom cop here instead

* Make it so it only checks spec files

* try to make this simpler

* Update version.rb

---------

Co-authored-by: Erin Osher <4386583+erinosher@users.noreply.github.com>

Author: jonmarkgo

.rubocop.yml

@@ -3,6 +3,8 @@ require:
   - rubocop-rails
   - rubocop-performance
   - rubocop-factory_bot
+  - rubocop-rspec_rails
+  - ./lib/custom/rack_utils_status_code
 
 Layout/FirstHashElementIndentation:
   Description: Enforces consistent indentation for the first key in a hash literal
@@ -151,3 +153,13 @@ Style/SymbolProc:
   Description: Allows block for method with arguments
   AllowMethodsWithArguments: true
   Enabled: true
+
+RSpecRails/HaveHttpStatus:
+  Enabled: true
+
+Rails/HttpStatus:
+  Enabled: true
+  EnforcedStyle: symbolic
+
+Custom/RackUtilsStatusCode:
+  Enabled: true

Gemfile

@@ -11,3 +11,4 @@ gem 'rubocop-factory_bot'
 gem 'rubocop-performance'
 gem 'rubocop-rails'
 gem 'rubocop-rspec'
+gem 'rubocop-rspec_rails'

lib/custom/rack_utils_status_code.rb

@@ -0,0 +1,82 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Custom
+      # This cop checks for uses of `Rack::Utils.status_code` in RSpec tests
+      # and suggests using `have_http_status` instead.
+      #
+      # @example
+      #   # bad
+      #   expect(response.status).to be(Rack::Utils.status_code(:created))
+      #
+      #   # good
+      #   expect(response).to have_http_status(:created)
+      class RackUtilsStatusCode < RuboCop::Cop::Base
+        extend AutoCorrector
+
+        MSG = 'Prefer `have_http_status` over `Rack::Utils.status_code`.'
+
+        def_node_matcher :rack_utils_status_code?, <<~PATTERN
+          (send 
+            (const 
+              (const nil? :Rack) :Utils) :status_code $_)
+        PATTERN
+
+        def_node_matcher :expect_response_status_pattern?, <<~PATTERN
+          (send
+            (send nil? :expect
+              (send $(send nil? _) :status)
+            )
+            $_
+            (send nil? {:be :eq :eql :equal}
+              (send
+                (const
+                  (const nil? :Rack) :Utils) :status_code $_)))
+        PATTERN
+
+        def on_send(node)
+          # Only proceed if we're in an expect statement
+          expect_node = find_expect_node(node)
+          return unless expect_node
+
+          rack_utils_status_code?(node) do |status_arg|
+            add_offense(node, message: MSG) do |corrector|
+              expect_response_status_pattern?(expect_node) do |response_obj, to_method, status_sym|
+                # Replace just the Rack::Utils.status_code part with have_http_status
+                replacement = "expect(#{response_obj.source}).#{to_method} have_http_status(#{status_sym.source})"
+                corrector.replace(expect_node, replacement)
+              end
+            end
+          end
+        end
+
+        private
+
+        # Find the expect(...).to be(Rack::Utils.status_code(...)) node
+        def find_expect_node(node)
+          return nil unless node
+
+          if node.send_type? && 
+             (node.method_name == :to || node.method_name == :to_not || node.method_name == :not_to) &&
+             node.receiver&.send_type? && 
+             node.receiver.method_name == :expect &&
+             node.first_argument&.send_type? && 
+             (node.first_argument.method_name == :be || 
+              node.first_argument.method_name == :eq || 
+              node.first_argument.method_name == :eql || 
+              node.first_argument.method_name == :equal)
+            
+            return node
+          end
+
+          if node.parent
+            find_expect_node(node.parent)
+          else
+            nil
+          end
+        end
+      end
+    end
+  end
+end

lib/mlh-rubocop-config/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MlhRubocopConfig
-  VERSION = '1.0.3'
+  VERSION = '2.0.0'
 end

mlh-rubocop-config.gemspec

@@ -21,4 +21,5 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'rubocop-performance'
   spec.add_dependency 'rubocop-rails'
   spec.add_dependency 'rubocop-rspec'
+  spec.add_dependency 'rubocop-rspec_rails'
 end