Changed pretty_date to handle empty input argument (#851)#856
Merged
bradchoate merged 1 commit intomasterfrom Oct 24, 2025
Merged
Changed pretty_date to handle empty input argument (#851)#856bradchoate merged 1 commit intomasterfrom
bradchoate merged 1 commit intomasterfrom
Conversation
* Added an empty arg check to pretty_date. Should probably never happen, though was getting an fatal error for what should be a minor data quality issue. * Based on PR feedback removed default None value (function typically expects one). Renamed function parameter 'time' to avoid any clashes with time std module. Added created_at value to admin user in test database to avoid original issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an empty arg check to pretty_date. Should probably never happen, though was getting an fatal error for what should be a minor data quality issue.
Based on PR feedback removed default None value (function typically expects one). Renamed function parameter 'time' to avoid any clashes with time std module. Added created_at value to admin user in test database to avoid original issue.