Skip to content

Commit 46e8bce

Browse files
committed
Refactor to use mmrl.compat and update platform intent usage
Replaced direct usage of platform intent extensions from model with Platform.Companion methods across app and webui modules. Updated dependencies to include mmrl.compat, removed local MediaStoreCompat in favor of mmrl.compat, and adjusted related imports. Also updated mmrl library version.
1 parent 430a422 commit 46e8bce

File tree

13 files changed

+19
-147
lines changed

13 files changed

+19
-147
lines changed

app/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,9 @@ dependencies {
168168
implementation(libs.mmrl.ui)
169169
implementation(libs.mmrl.platform)
170170
implementation(libs.mmrl.datastore)
171+
implementation(libs.mmrl.compat)
171172
compileOnly(libs.mmrl.hiddenApi)
173+
172174
implementation(libs.libsu.core)
173175
implementation(libs.libsu.service)
174176
implementation(libs.libsu.io)

app/src/main/java/com/dergoogler/mmrl/wx/service/PlatformService.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import androidx.core.app.ServiceCompat
1010
import androidx.lifecycle.LifecycleService
1111
import androidx.lifecycle.lifecycleScope
1212
import com.dergoogler.mmrl.platform.Platform
13-
import com.dergoogler.mmrl.platform.model.PlatformIntent.Companion.getPlatform
14-
import com.dergoogler.mmrl.platform.model.createPlatformIntent
13+
import com.dergoogler.mmrl.platform.Platform.Companion.createPlatformIntent
14+
import com.dergoogler.mmrl.platform.Platform.Companion.getPlatform
1515
import com.dergoogler.mmrl.wx.R
1616
import com.dergoogler.mmrl.wx.app.utils.NotificationUtils.CHANNEL_ID_PLATFORM
1717
import com.dergoogler.mmrl.wx.app.utils.NotificationUtils.GROUP_KEY_PLATFORM
@@ -41,7 +41,7 @@ class PlatformService : LifecycleService() {
4141
}
4242

4343
lifecycleScope.launch {
44-
isActive = initPlatform(baseContext, intent.getPlatform())
44+
isActive = initPlatform(baseContext, intent.getPlatform() ?: return@launch)
4545
}
4646

4747
return START_STICKY

app/src/main/java/com/dergoogler/mmrl/wx/util/BaseActivity.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ import androidx.navigation.compose.rememberNavController
1616
import com.dergoogler.mmrl.datastore.UserPreferencesRepository
1717
import com.dergoogler.mmrl.datastore.model.UserPreferences
1818
import com.dergoogler.mmrl.datastore.providable.LocalUserPreferences
19-
import com.dergoogler.mmrl.platform.Platform
20-
import com.dergoogler.mmrl.platform.model.PlatformIntent.Companion.getPlatform
19+
import com.dergoogler.mmrl.platform.Platform.Companion.getPlatform
2120
import com.dergoogler.mmrl.ui.providable.LocalNavController
2221
import com.dergoogler.mmrl.ui.theme.MMRLAppTheme
2322
import com.dergoogler.mmrl.wx.App.Companion.TAG
@@ -90,7 +89,7 @@ fun BaseActivity.setBaseContent(
9089
}
9190

9291
fun ComponentActivity.initPlatform(userPreferences: UserPreferences) {
93-
val platform = (intent.getPlatform() as Platform?) ?: userPreferences.workingMode.toPlatform()
92+
val platform = intent.getPlatform() ?: userPreferences.workingMode.toPlatform()
9493

9594
if (!PlatformService.isActive) {
9695
try {

app/src/main/java/com/dergoogler/mmrl/wx/util/NonRootProvider.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import android.app.Service
44
import android.content.Context
55
import android.content.ServiceConnection
66
import com.dergoogler.mmrl.platform.Platform
7+
import com.dergoogler.mmrl.platform.Platform.Companion.createPlatformIntent
78
import com.dergoogler.mmrl.platform.model.IProvider
8-
import com.dergoogler.mmrl.platform.model.createPlatformIntent
99

1010
class NonRootProvider(
1111
private val context: Context,

app/src/main/java/com/dergoogler/mmrl/wx/util/NonRootService.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ package com.dergoogler.mmrl.wx.util
33
import android.app.Service
44
import android.content.Intent
55
import android.os.IBinder
6-
import com.dergoogler.mmrl.platform.model.PlatformIntent.Companion.getPlatform
6+
import com.dergoogler.mmrl.platform.Platform.Companion.getPlatform
77

88
class NonRootService : Service() {
99
override fun onBind(intent: Intent): IBinder {
10-
val mode = intent.getPlatform()
10+
val mode = intent.getPlatform() ?: throw Exception("Platform not found")
1111
return NonServiceManager(mode)
1212
}
1313
}

app/src/main/java/com/dergoogler/mmrl/wx/util/RootProvider.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ package com.dergoogler.mmrl.wx.util
33
import android.content.Context
44
import android.content.ServiceConnection
55
import com.dergoogler.mmrl.platform.Platform
6+
import com.dergoogler.mmrl.platform.Platform.Companion.createPlatformIntent
67
import com.dergoogler.mmrl.platform.model.IProvider
7-
import com.dergoogler.mmrl.platform.model.createPlatformIntent
88
import com.topjohnwu.superuser.Shell
99
import com.topjohnwu.superuser.ipc.RootService
1010
import kotlinx.coroutines.suspendCancellableCoroutine

app/src/main/java/com/dergoogler/mmrl/wx/util/SuService.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ package com.dergoogler.mmrl.wx.util
22

33
import android.content.Intent
44
import android.os.IBinder
5-
import com.dergoogler.mmrl.platform.model.PlatformIntent.Companion.getPlatform
5+
import com.dergoogler.mmrl.platform.Platform.Companion.getPlatform
66
import com.dergoogler.mmrl.platform.service.ServiceManager
77
import com.topjohnwu.superuser.ipc.RootService
88

99
class SuService : RootService() {
1010
override fun onBind(intent: Intent): IBinder {
11-
val mode = intent.getPlatform()
11+
val mode = intent.getPlatform() ?: throw Exception("Platform not found")
1212
return ServiceManager(mode)
1313
}
1414
}

gradle/libs.versions.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[versions]
2-
mmrl = "52140b4c92"
2+
mmrl = "7d178829fe"
33
adaptiveAndroid = "1.1.0-rc01"
44
androidGradlePlugin = "8.9.1"
55
androidxActivity = "1.9.3"
@@ -62,6 +62,7 @@ mmrl-platform = { group = "com.github.MMRLApp.MMRL", name = "platform", version.
6262
mmrl-hiddenApi = { group = "com.github.MMRLApp.MMRL", name = "hidden-api", version.ref = "mmrl" }
6363
mmrl-ui = { group = "com.github.MMRLApp.MMRL", name = "ui", version.ref = "mmrl" }
6464
mmrl-ext = { group = "com.github.MMRLApp.MMRL", name = "ext", version.ref = "mmrl" }
65+
mmrl-compat = { group = "com.github.MMRLApp.MMRL", name = "compat", version.ref = "mmrl" }
6566
mmrl-datastore = { group = "com.github.MMRLApp.MMRL", name = "datastore", version.ref = "mmrl" }
6667
androidx-swiperefreshlayout = { group = "androidx.swiperefreshlayout", name = "swiperefreshlayout", version.ref = "swiperefreshlayout" }
6768
androidx-adaptive = { module = "androidx.compose.material3.adaptive:adaptive", version.ref = "adaptiveAndroid" }

webui/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ dependencies {
4545
compileOnly(libs.mmrl.ext)
4646
compileOnly(libs.mmrl.ui)
4747
compileOnly(libs.mmrl.platform)
48+
compileOnly(libs.mmrl.compat)
4849
compileOnly(libs.mmrl.hiddenApi)
4950
implementation(libs.libsu.core)
5051
implementation(libs.androidx.core.ktx)

webui/src/main/kotlin/com/dergoogler/mmrl/webui/activity/WXActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import androidx.compose.runtime.getValue
1818
import androidx.compose.runtime.mutableStateOf
1919
import androidx.compose.runtime.setValue
2020
import androidx.compose.ui.graphics.toArgb
21-
import com.dergoogler.mmrl.ext.BuildCompat
21+
import com.dergoogler.mmrl.compat.BuildCompat
2222
import com.dergoogler.mmrl.ext.nullply
2323
import com.dergoogler.mmrl.platform.model.ModId
2424
import com.dergoogler.mmrl.platform.model.ModId.Companion.getModId

0 commit comments

Comments
 (0)