refactor(prt): consolidate cell exit event raising logic (#2458)

Override try_pass in the cell-level method and raise a cell exit event there instead of separately in the various cell-level methods. Fix a recently introduced issue where cell exits weren't raised by the quad pollock method.

Author: wpbonelli

src/Solution/ParticleTracker/Method/MethodCell.f90

@@ -4,7 +4,7 @@ module MethodCellModule
   use ErrorUtilModule, only: pstop
   use ConstantsModule, only: DONE, DZERO
   use MethodModule, only: MethodType, LEVEL_FEATURE
-  use ParticleModule, only: ParticleType, TERM_NO_EXITS, TERM_BOUNDARY
+  use ParticleModule, only: ParticleType, ACTIVE, TERM_NO_EXITS, TERM_BOUNDARY
   use ParticleEventModule, only: ParticleEventType
   use CellExitEventModule, only: CellExitEventType
   use CellDefnModule, only: CellDefnType
@@ -21,9 +21,33 @@ module MethodCellModule
     procedure, public :: forms_cycle
     procedure, public :: store_event
     procedure, public :: get_level
+    procedure, public :: try_pass
   end type MethodCellType
 
 contains
+  !> @brief Try passing the particle to the next subdomain.
+  subroutine try_pass(this, particle, nextlevel, advancing)
+    class(MethodCellType), intent(inout) :: this
+    type(ParticleType), pointer, intent(inout) :: particle
+    integer(I4B) :: nextlevel
+    logical(LGP) :: advancing
+
+    if (particle%advancing) then
+      ! if still advancing, pass to the next subdomain.
+      ! if that puts us on a boundary, then we're done.
+      ! raise a cell exit event.
+      call this%pass(particle)
+      if (particle%iboundary(nextlevel - 1) .ne. 0) then
+        advancing = .false.
+        call this%cellexit(particle)
+      end if
+    else
+      ! otherwise we're already done so
+      ! reset the domain boundary value.
+      advancing = .false.
+      particle%iboundary = 0
+    end if
+  end subroutine try_pass
 
   !> @brief Check reporting/terminating conditions before tracking
   !! the particle across the cell.

src/Solution/ParticleTracker/Method/MethodCellPollock.f90

@@ -151,8 +151,6 @@ subroutine apply_mcp(this, particle, tmax)
                               sinrot, cosrot, invert=.true.)
       call particle%reset_transform()
     end select
-
-    if (particle%iboundary(LEVEL_FEATURE) > 0) call this%cellexit(particle)
   end subroutine apply_mcp
 
   !> @brief Loads the lone rectangular subcell from the rectangular cell

src/Solution/ParticleTracker/Method/MethodCellTernary.f90

@@ -242,8 +242,6 @@ subroutine apply_mct(this, particle, tmax)
       call particle%transform(xO, yO, invert=.true.)
       call particle%reset_transform()
     end select
-
-    if (particle%iboundary(LEVEL_FEATURE) > 0) call this%cellexit(particle)
   end subroutine apply_mct
 
   !> @brief Loads a triangular subcell from the polygonal cell