Profiling is turned on by default and can't be turned off

[p-ortega]

Hi dev team,

I apologise for the basic description of this and if is the intended behaviour, but I've encountered this when running a mf6 sim with several transport models.

Describe the bug
The profiling option is always on by default and the following does not turn it off:

BEGIN options
  PROFILE_OPTION NONE
END options

To reproduce
I have attached a multi-species model that hits the MAX_NR_TIMED_SECTIONS when profiling is turned on.
issue.tar.gz

Expected behavior
Profiling off by default and be able to turn it off using the block option

Environment

• Same issue across Linux, MacOS, and Windows.
• MODFLOW 6 version 6.6.2, 6.6.3 and 6.7.0-dev from nightly build.

Context
I got this when I was testing a mf6api application across platforms.
example

[mjr-deltares]

hi @p-ortega , thank you for reporting this! There is some improvement required for the profiling tool. I think that your example shows that using MAX_NR_TIMED_SECTIONS was a bad idea because there is no sensible maximum to be defined. Increasing the number of species will eventually always lead to the problem your are experiencing. I will look into making the container with profiling data dynamically sized which should solve that. Setting profiling to NONE currently only cancels the printing of the numbers but not the actual measurements, and therefore doesn't help you. We will change that as well.