Addressing review comments

Combining some OpenACC loops and parallel regions.

Some whitespace changes.

Removing redundant calls to mpas_pool_get_array.

Author: abishekg7

src/core_atmosphere/dynamics/mpas_atm_boundaries.F

@@ -170,9 +170,9 @@ subroutine mpas_atm_update_bdy_tend(clock, streamManager, block, firstCall, ierr
         ! Compute any derived fields from those that were read from the lbc_in stream
         !
         call mpas_pool_get_array(lbc, 'lbc_u', u, 2)
-        call mpas_pool_get_array(lbc, 'lbc_w', w, 2)
         call mpas_pool_get_array(lbc, 'lbc_ru', ru, 2)
         call mpas_pool_get_array(lbc, 'lbc_rho_edge', rho_edge, 2)
+        call mpas_pool_get_array(lbc, 'lbc_w', w, 2)
         call mpas_pool_get_array(lbc, 'lbc_theta', theta, 2)
         call mpas_pool_get_array(lbc, 'lbc_rtheta_m', rtheta_m, 2)
         call mpas_pool_get_array(lbc, 'lbc_rho_zz', rho_zz, 2)
@@ -221,7 +221,6 @@ subroutine mpas_atm_update_bdy_tend(clock, streamManager, block, firstCall, ierr
         !$acc end kernels
 
         !$acc parallel
-        ! Compute lbc_rho_zz
         !$acc loop gang vector collapse(2)
         do iCell=1,nCells+1
             do k=1,nVertLevels
@@ -267,26 +266,6 @@ subroutine mpas_atm_update_bdy_tend(clock, streamManager, block, firstCall, ierr
             dt = 86400.0_RKIND * real(dd_intv, kind=RKIND) + real(s_intv, kind=RKIND) &
                  + (real(sn_intv, kind=RKIND) / real(sd_intv, kind=RKIND))
 
-            call mpas_pool_get_array(lbc, 'lbc_u', u, 2)
-            call mpas_pool_get_array(lbc, 'lbc_ru', ru, 2)
-            call mpas_pool_get_array(lbc, 'lbc_rho_edge', rho_edge, 2)
-            call mpas_pool_get_array(lbc, 'lbc_w', w, 2)
-            call mpas_pool_get_array(lbc, 'lbc_theta', theta, 2)
-            call mpas_pool_get_array(lbc, 'lbc_rtheta_m', rtheta_m, 2)
-            call mpas_pool_get_array(lbc, 'lbc_rho_zz', rho_zz, 2)
-            call mpas_pool_get_array(lbc, 'lbc_rho', rho, 2)
-            call mpas_pool_get_array(lbc, 'lbc_scalars', scalars, 2)
-
-            call mpas_pool_get_array(lbc, 'lbc_u', lbc_tend_u, 1)
-            call mpas_pool_get_array(lbc, 'lbc_ru', lbc_tend_ru, 1)
-            call mpas_pool_get_array(lbc, 'lbc_rho_edge', lbc_tend_rho_edge, 1)
-            call mpas_pool_get_array(lbc, 'lbc_w', lbc_tend_w, 1)
-            call mpas_pool_get_array(lbc, 'lbc_theta', lbc_tend_theta, 1)
-            call mpas_pool_get_array(lbc, 'lbc_rtheta_m', lbc_tend_rtheta_m, 1)
-            call mpas_pool_get_array(lbc, 'lbc_rho_zz', lbc_tend_rho_zz, 1)
-            call mpas_pool_get_array(lbc, 'lbc_rho', lbc_tend_rho, 1)
-            call mpas_pool_get_array(lbc, 'lbc_scalars', lbc_tend_scalars, 1)
-
 
             dt = 1.0_RKIND / dt
 
@@ -296,13 +275,7 @@ subroutine mpas_atm_update_bdy_tend(clock, streamManager, block, firstCall, ierr
                 do k=1,nVertLevels
                     lbc_tend_u(k,iEdge) = (u(k,iEdge) - lbc_tend_u(k,iEdge)) * dt
                     lbc_tend_ru(k,iEdge) = (ru(k,iEdge) - lbc_tend_ru(k,iEdge)) * dt
-                end do
-            end do
-
-            !$acc loop gang vector collapse(2)
-             do iEdge=1,nEdges+1
-                 do k=1,nVertLevels
-                     lbc_tend_rho_edge(k,iEdge) = (rho_edge(k,iEdge) - lbc_tend_rho_edge(k,iEdge)) * dt
+                    lbc_tend_rho_edge(k,iEdge) = (rho_edge(k,iEdge) - lbc_tend_rho_edge(k,iEdge)) * dt
                  end do
              end do
 
@@ -318,25 +291,17 @@ subroutine mpas_atm_update_bdy_tend(clock, streamManager, block, firstCall, ierr
                 do k=1,nVertLevels
                     lbc_tend_theta(k,iCell) = (theta(k,iCell) - lbc_tend_theta(k,iCell)) * dt
                     lbc_tend_rtheta_m(k,iCell) = (rtheta_m(k,iCell) - lbc_tend_rtheta_m(k,iCell)) * dt
-                end do
-            end do
-
-            !$acc loop gang vector collapse(2)
-            do iCell=1,nCells+1
-                do k=1,nVertLevels
                     lbc_tend_rho_zz(k,iCell) = (rho_zz(k,iCell) - lbc_tend_rho_zz(k,iCell)) * dt
                     lbc_tend_rho(k,iCell) = (rho(k,iCell) - lbc_tend_rho(k,iCell)) * dt
                 end do
             end do
-            !$acc end parallel
-
-            !$acc parallel default(present)
+ 
             !$acc loop gang
             do iCell=1,nCells+1
                 !$acc loop vector collapse(2)
                 do k=1,nVertLevels
                     do j = 1,nScalars
-                    lbc_tend_scalars(j,k,iCell) = (scalars(j,k,iCell) - lbc_tend_scalars(j,k,iCell)) * dt
+                        lbc_tend_scalars(j,k,iCell) = (scalars(j,k,iCell) - lbc_tend_scalars(j,k,iCell)) * dt
                     end do
                 end do
             end do