Skip to content

Commit ecad6a7

Browse files
committed
style: markdown files cleanup
1 parent 75b63f3 commit ecad6a7

File tree

7 files changed

+75
-66
lines changed

7 files changed

+75
-66
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ after_success:
120120
# Generate and deploy documentation only in linux g++
121121
- if [ "$EXTENDED_BUILD" == "ON" ]; then
122122
cd ${TRAVIS_BUILD_DIR} ;
123+
cp ${TRAVIS_BUILD_DIR}/scriptsBuild/generateDocumentationAndDeploy.sh generateDocumentationAndDeploy.sh;
123124
chmod +x generateDocumentationAndDeploy.sh;
124125
./generateDocumentationAndDeploy.sh;
125126
fi

CONTRIBUTING.md

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -17,34 +17,34 @@ We use GitHub issues to track public bugs. Report a bug by [opening a new issue]
1717
## Pull Requests
1818
We actively welcome your pull requests.
1919

20-
1. Fork the repo and create your branch from `master`.
21-
2. If you've added code that should be tested, add tests.
22-
3. If you've changed APIs, update the documentation.
23-
4. Ensure the test suite passes.
24-
5. Make sure your code lints.
25-
6. Issue that pull request!
20+
1. Fork the repo and create your branch from `master`.
21+
2. If you've added code that should be tested, add tests.
22+
3. If you've changed APIs, update the documentation.
23+
4. Ensure the test suite passes.
24+
5. Make sure your code lints.
25+
6. Issue that pull request!
2626

2727
## Any contributions you make will be under the MIT Software License
28-
In short, when you submit code changes, your submissions are understood to be under the same
29-
[MIT License](http://choosealicense.com/licenses/mit/) that covers the project.
28+
In short, when you submit code changes, your submissions are understood to be under the same
29+
[MIT License](http://choosealicense.com/licenses/mit/) that covers the project.
3030
Feel free to contact the maintainers if that's a concern.
3131

3232
## Coding style
33-
* Write code compatible with C++98
34-
* Use underscore (`_variable`) in the name of a class member variable.
35-
* C++98 does not allow me to use constructor delegation. Using methods like `setAllPointersToNull()` to make up for it.
36-
* Order of methods in a class definition:
37-
* functional (calculation, helpers etc)
38-
* getters/setters
39-
* disp()
40-
* constructors/destructors
41-
* In **copy constructors** copy primitive types, set all pointers to zero.
33+
* Write code compatible with C++98
34+
* Use underscore (`_variable`) in the name of a class member variable.
35+
* C++98 does not allow me to use constructor delegation. Using methods like `setAllPointersToNull()` to make up for it.
36+
* Order of methods in a class definition:
37+
* functional (calculation, helpers etc)
38+
* getters/setters
39+
* disp()
40+
* constructors/destructors
41+
* In **copy constructors** copy primitive types, set all pointers to zero.
4242

4343
## License
4444
By contributing to Draft.js, you agree that your contributions will be licensed
4545
under its BSD license.
4646

4747
## References
48-
This document was adapted from the open-source contribution guidelines for
49-
[Facebook's Draft](https://github.com/facebook/draft-js/blob/a9316a723f9e918afde44dea68b5f9f39b7d9b00/CONTRIBUTING.md)
50-
and [qMRLab](https://github.com/qMRLab/qMRLab/blob/master/CONTRIBUTING.md).
48+
This document was adapted from the open-source contribution guidelines for
49+
[Facebook's Draft](https://github.com/facebook/draft-js/blob/a9316a723f9e918afde44dea68b5f9f39b7d9b00/CONTRIBUTING.md)
50+
and [qMRLab](https://github.com/qMRLab/qMRLab/blob/master/CONTRIBUTING.md).

README.md

Lines changed: 34 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# Tomato
2+
23
A library to calculate parametric maps in MRI. It contains ShMOLLI implementation as in [this article](https://jcmr-online.biomedcentral.com/articles/10.1186/1532-429X-12-69).
34
**Github** repository can be found [here](https://github.com/MRKonrad/tomato).
45
**Documentation** in doxygen can be found [here](https://mrkonrad.github.io/tomato/html).
@@ -14,50 +15,56 @@ A library to calculate parametric maps in MRI. It contains ShMOLLI implementatio
1415

1516

1617
# Usage
17-
* App - download the latest version of `TomatoExe` from the [Releases][downloads_link] page and follow the youtube tutorial below
18+
19+
* App - download the latest version of `TomatoExe` from the [Releases][downloads_link] page and follow the youtube tutorial below
1820
[![Tomato tutorial](https://img.youtube.com/vi/0tzNZNiZh18/0.jpg)](https://www.youtube.com/watch?v=0tzNZNiZh18)
19-
* Lib - download the latest version of `TomatoLib` from the [Releases][downloads_link] page
20-
* Code - if you want to build the code please take a look at the scripts in the `scriptsBuild` and the continuous integrations scripts `.appveyor.yml` and `travis.yml`
21+
* Lib - download the latest version of `TomatoLib` from the [Releases][downloads_link] page
22+
* Code - if you want to build the code please take a look at the scripts in the `scriptsBuild` and the continuous integrations scripts `.appveyor.yml` and `travis.yml`
2123

2224
## Tomato and Numerical Recipes
2325

2426
**Important**
2527
Original ShMOLLI (and based on it Tomato) uses code based on Numerical Recipes book. Due to Numerical Recipes licence I cannot share this part of the code online. Please contact me if you would like to use this part of the code. To make up for this limitation we provide a number of alternative fitting procedures.
2628

2729
# Troubleshooting
28-
* missing msvcp140.dll
29-
Download https://www.microsoft.com/en-us/download/details.aspx?id=48145 as suggested in https://stackoverflow.com/questions/32998902/msvcp140-dll-missing
30+
31+
* missing msvcp140.dll
32+
Download <https://www.microsoft.com/en-us/download/details.aspx?id=48145> as suggested in <https://stackoverflow.com/questions/32998902/msvcp140-dll-missing>
3033

3134
# Software Requirements Specification
3235

33-
1. Calculate ShMOLLI with exactly the same results as these from the previous implementation.
34-
2. API for easily choosing
35-
* a map calculation algorithm,
36-
* a fitting algorithm,
37-
* a model function and corresponding energy function.
38-
3. Compatibility with:
39-
* main operating systems (Windows, MacOS, Linux),
40-
* C++98 (to include the library in older code).
41-
4. Handling DICOM files.
42-
5. Fast calculation.
43-
6. Easily interfaced to calculation environments MATLAB, IDL and Python.
36+
1. Calculate ShMOLLI with exactly the same results as these from the previous implementation.
37+
2. API for easily choosing
38+
* a map calculation algorithm,
39+
* a fitting algorithm,
40+
* a model function and corresponding energy function.
41+
3. Compatibility with:
42+
* main operating systems (Windows, MacOS, Linux),
43+
* C++98 (to include the library in older code).
44+
4. Handling DICOM files.
45+
5. Fast calculation.
46+
6. Easily interfaced to calculation environments MATLAB, IDL and Python.
47+
48+
# Contributing and code of conduct
49+
50+
Please see [contributing.md](contributing.md) and [codeofconduct.md](codeofconduct.md).
4451

4552
# Notes
4653

47-
* **Continuous integration** was tested [in this repo](https://github.com/MRKonrad/ContinousIntegrationPlayground).
48-
* **Gitmodules**: after `git clone` run `git submodule update --init --recursive` to get the submodules code.
49-
* It would be nice to follow [CppCoreGuidlines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md) as far as C++98 allows.
50-
* Maybe I can write a script for github releases with [github releases REST api](https://developer.github.com/v3/repos/releases/#create-a-release) and [curl REST api](http://www.codingpedia.org/ama/how-to-test-a-rest-api-from-command-line-with-curl/#12_HEAD_requests)?
51-
* LMFIT - somehow windows does not like the static library, so the dynamic is used
54+
* **Continuous integration** was tested [in this repo](https://github.com/MRKonrad/ContinousIntegrationPlayground).
55+
* **Gitmodules**: after `git clone` run `git submodule update --init --recursive` to get the submodules code.
56+
* It would be nice to follow [CppCoreGuidlines](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md) as far as C++98 allows.
57+
* Maybe I can write a script for github releases with [github releases REST api](https://developer.github.com/v3/repos/releases/#create-a-release) and [curl REST api](http://www.codingpedia.org/ama/how-to-test-a-rest-api-from-command-line-with-curl/#12_HEAD_requests)?
58+
* LMFIT - somehow windows does not like the static library, so the dynamic is used
5259

5360
# TODO:
5461

55-
* output SNR maps
56-
* make sure SNR and nAmoebaCalls is the same as in Shmolli
57-
* fix downloadITK_linux_osx
58-
* seperate projects for building tomato dependencies (done for lmfit)
59-
* possibly I could make all FunctionsT1 object static
60-
* write user-friendly build scripts (and use them in CI)
62+
* output SNR maps
63+
* make sure SNR and nAmoebaCalls is the same as in Shmolli
64+
* fix downloadITK_linux_osx
65+
* seperate projects for building tomato dependencies (done for lmfit)
66+
* possibly I could make all FunctionsT1 object static
67+
* write user-friendly build scripts (and use them in CI)
6168

6269
[zenodo_link]: https://zenodo.org/badge/latestdoi/142749215
6370
[zenodo_badge]: https://img.shields.io/badge/DOI-10.5281%2Fzenodo.1489791-blue.svg?style=flat-square
Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,21 @@ appearance, race, religion, or sexual identity and orientation.
1414
Examples of behavior that contributes to creating a positive environment
1515
include:
1616

17-
* Using welcoming and inclusive language
18-
* Being respectful of differing viewpoints and experiences
19-
* Gracefully accepting constructive criticism
20-
* Focusing on what is best for the community
21-
* Showing empathy towards other community members
17+
* Using welcoming and inclusive language
18+
* Being respectful of differing viewpoints and experiences
19+
* Gracefully accepting constructive criticism
20+
* Focusing on what is best for the community
21+
* Showing empathy towards other community members
2222

2323
Examples of unacceptable behavior by participants include:
2424

25-
* The use of sexualized language or imagery and unwelcome sexual attention or
25+
* The use of sexualized language or imagery and unwelcome sexual attention or
2626
advances
27-
* Trolling, insulting/derogatory comments, and personal or political attacks
28-
* Public or private harassment
29-
* Publishing others' private information, such as a physical or electronic
27+
* Trolling, insulting/derogatory comments, and personal or political attacks
28+
* Public or private harassment
29+
* Publishing others' private information, such as a physical or electronic
3030
address, without explicit permission
31-
* Other conduct which could reasonably be considered inappropriate in a
31+
* Other conduct which could reasonably be considered inappropriate in a
3232
professional setting
3333

3434
## Our Responsibilities
@@ -68,9 +68,9 @@ members of the project's leadership.
6868
## Attribution
6969

7070
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
71-
available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
71+
available at <https://www.contributor-covenant.org/version/1/4/code-of-conduct.html>
7272

73-
[homepage]: https://www.contributor-covenant.org
73+
[homepage]: <https://www.contributor-covenant.org>
7474

7575
For answers to common questions about this code of conduct, see
76-
https://www.contributor-covenant.org/faq
76+
<https://www.contributor-covenant.org/faq>

notepad.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Different results from the configurations:
1+
# Different results from the configurations
22

33
parameter_to_map: T1_SHMOLLI
44
functions_type: **FunctionsBasic/FunctionsShmolli**
@@ -23,4 +23,5 @@ Default: 2.2s and wrong results
2323
StartPointSHMOLLI: 10s and seemingly correct results
2424

2525
# 5 vs 7 samples
26-
5 samples are calculated way slower. Maybe playing with fmax and maxIter would reduce the time?
26+
27+
5 samples are calculated way slower. Maybe playing with fmax and maxIter would reduce the time?

generateDocumentationAndDeploy.sh renamed to scriptsBuild/generateDocumentationAndDeploy.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Title : generateDocumentationAndDeploy.sh
44
# Date created : 2016/02/22
55
# Notes :
6-
__AUTHOR__="Jeroen de Bruijn"
6+
# __AUTHOR__="Konrad Werys"
77
# Preconditions:
88
# - Packages doxygen doxygen-doc doxygen-latex doxygen-gui graphviz
99
# must be installed.
@@ -109,4 +109,4 @@ else
109109
echo 'Warning: No documentation (html) files have been found!' >&2
110110
echo 'Warning: Not going to push the documentation to GitHub!' >&2
111111
exit 1
112-
fi
112+
fi

scriptsPython/tomatoPython.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@
3131
yaml_data = myfile.read()
3232
yaml = YAML()
3333
yaml_dict = yaml.load(yaml_data)
34-
35-
# ### 2.c. define/modify params in the structure. Input params are obligatory for calculation, the rest are optional
3634

35+
# ### 2.c. define/modify params in the structure. Input params are obligatory for calculation, the rest are optional
36+
3737
# ## input params ##
3838
yaml_dict['files_magnitude'] = ''
3939
yaml_dict['files_phase'] = ''

0 commit comments

Comments
 (0)