Skip to content

Commit 933c7a2

Browse files
committed
Fix clang-tidy warnings in LockHelper
1 parent 059843b commit 933c7a2

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

libs/core/include/mrpt/core/lock_helper.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class LockHelper
2222
using Tnc = std::remove_const_t<T>;
2323

2424
public:
25-
LockHelper(const Tnc* l) : l_{const_cast<Tnc*>(l)} { l_->lock(); }
25+
explicit LockHelper(const Tnc* l) : l_{const_cast<Tnc*>(l)} { l_->lock(); }
2626
~LockHelper()
2727
{
2828
if (l_) l_->unlock();
@@ -31,11 +31,11 @@ class LockHelper
3131
LockHelper(const LockHelper& o) = delete;
3232
LockHelper& operator=(const LockHelper& o) = delete;
3333

34-
LockHelper(LockHelper&& o) : l_{o.l} { o.l = nullptr; }
34+
LockHelper(LockHelper&& o) : l_{o.l_} { o.l_ = nullptr; }
3535
LockHelper& operator=(LockHelper&& o)
3636
{
37-
l_ = o.l;
38-
o.l = nullptr;
37+
l_ = o.l_;
38+
o.l_ = nullptr;
3939
return *this;
4040
}
4141

0 commit comments

Comments
 (0)