[DOP-32998] Make tag facets immutable

Author: dolfinus

data_rentgen/consumer/extractors/generic/run.py

@@ -20,6 +20,7 @@
     OpenLineageParentJob,
     OpenLineageParentRunFacet,
 )
+from data_rentgen.openlineage.run_facets.run_tags import OpenLineageRunTagsFacetField
 
 
 class RunExtractorMixin(ABC):
@@ -103,8 +104,10 @@ def _add_openlineage_client_version_tag(self, run: RunDTO, event: OpenLineageRun
         if not event.run.facets.tags:
             return run
 
-        for i, raw_tag in enumerate(event.run.facets.tags.tags.copy()):
+        run_tags: list[OpenLineageRunTagsFacetField] = []
+        for raw_tag in event.run.facets.tags.tags:
             if raw_tag.key != "openlineage_client_version":
+                run_tags.append(raw_tag)
                 continue
 
             # https://github.com/OpenLineage/OpenLineage/blob/1.42.1/client/python/src/openlineage/client/client.py#L460
@@ -113,8 +116,9 @@ def _add_openlineage_client_version_tag(self, run: RunDTO, event: OpenLineageRun
                 value=raw_tag.value,
             )
             run.job.tag_values.add(client_tag_value)
-            # avoid passing this tag to _enrich_run_tags
-            event.run.facets.tags.tags.pop(i)
+
+        # avoid passing this tag to _enrich_run_tags
+        event.run.facets.tags.tags[:] = run_tags
         return run
 
     # Job and Run tags are different from OpenLineage spec perspective,

data_rentgen/consumer/extractors/impl/dbt.py

@@ -11,6 +11,7 @@
     OpenLineageSymlinkIdentifier,
 )
 from data_rentgen.openlineage.run_event import OpenLineageRunEvent
+from data_rentgen.openlineage.run_facets import OpenLineageRunTagsFacet, OpenLineageRunTagsFacetField
 
 
 class DbtExtractor(GenericExtractor):
@@ -62,14 +63,19 @@ def _enrich_run_tags(self, run: RunDTO, event: OpenLineageRunEvent) -> RunDTO:
         if not event.run.facets.tags:
             return run
 
+        run_tags: list[OpenLineageRunTagsFacetField] = []
         for raw_tag in event.run.facets.tags.tags:
             if raw_tag.value == "true" and ":" in raw_tag.key:
                 # not implemented in OpenLineage yet
                 # https://github.com/OpenLineage/OpenLineage/issues/4281
 
-                raw_tag.key, raw_tag.value, raw_tag.source = parse_kv_tag(
+                key, value, source = parse_kv_tag(
                     raw_tag.key,
                     default_source=raw_tag.source or "DBT",
                 )
+                run_tags.append(OpenLineageRunTagsFacetField(key=key, value=value, source=source))
+            else:
+                run_tags.append(raw_tag)
 
+        object.__setattr__(event.run.facets, "tags", OpenLineageRunTagsFacet(tags=run_tags))
         return super()._enrich_run_tags(run, event)

data_rentgen/openlineage/dataset_facets/dataset_tags.py

@@ -1,12 +1,13 @@
 # SPDX-FileCopyrightText: 2024-present MTS PJSC
 # SPDX-License-Identifier: Apache-2.0
 
-from pydantic import BaseModel, Field
+from pydantic import Field
 
+from data_rentgen.openlineage.base import OpenLineageBase
 from data_rentgen.openlineage.dataset_facets.base import OpenLineageDatasetFacet
 
 
-class OpenLineageDatasetTagsFacetField(BaseModel):
+class OpenLineageDatasetTagsFacetField(OpenLineageBase):
     """Dataset tags field type.
     See [TagsDatasetFacet](https://github.com/OpenLineage/OpenLineage/blob/main/spec/facets/TagsDatasetFacet.json).
     """

data_rentgen/openlineage/job_facets/job_tags.py

@@ -1,12 +1,13 @@
 # SPDX-FileCopyrightText: 2024-present MTS PJSC
 # SPDX-License-Identifier: Apache-2.0
 
-from pydantic import BaseModel, Field
+from pydantic import Field
 
+from data_rentgen.openlineage.base import OpenLineageBase
 from data_rentgen.openlineage.job_facets.base import OpenLineageJobFacet
 
 
-class OpenLineageJobTagsFacetField(BaseModel):
+class OpenLineageJobTagsFacetField(OpenLineageBase):
     """Job tags field type.
     See [TagsJobFacet](https://github.com/OpenLineage/OpenLineage/blob/main/spec/facets/TagsJobFacet.json).
     """

data_rentgen/openlineage/run_facets/run_tags.py

@@ -1,12 +1,13 @@
 # SPDX-FileCopyrightText: 2024-present MTS PJSC
 # SPDX-License-Identifier: Apache-2.0
 
-from pydantic import BaseModel, Field
+from pydantic import Field
 
+from data_rentgen.openlineage.base import OpenLineageBase
 from data_rentgen.openlineage.run_facets.base import OpenLineageRunFacet
 
 
-class OpenLineageRunTagsFacetField(BaseModel):
+class OpenLineageRunTagsFacetField(OpenLineageBase):
     """Run tags field type.
     See [TagsRunFacet](https://github.com/OpenLineage/OpenLineage/blob/main/spec/facets/TagsRunFacet.json).
     """