[DOP-22300] add increment_by field

Author: Zabilsya

src/entities/connection/ui/ConnectionTypeForm/components/ConnectionAuthBasic/index.tsx

@@ -8,7 +8,9 @@ export const ConnectionAuthBasic = () => {
 
   return (
     <>
-      <Form.Item name={['auth_data', 'type']} hidden />
+      <Form.Item name={['auth_data', 'type']} hidden>
+        <Input size="large" />
+      </Form.Item>
       <Form.Item label="User" name={['auth_data', 'user']} rules={[{ required: true }]}>
         <Input size="large" />
       </Form.Item>

src/entities/connection/ui/ConnectionTypeForm/components/ConnectionAuthS3/index.tsx

@@ -8,7 +8,9 @@ export const ConnectionAuthS3 = () => {
 
   return (
     <>
-      <Form.Item name={['auth_data', 'type']} hidden />
+      <Form.Item name={['auth_data', 'type']} hidden>
+        <Input size="large" />
+      </Form.Item>
       <Form.Item label="Access key" name={['auth_data', 'access_key']} rules={[{ required: true }]}>
         <Input size="large" />
       </Form.Item>

src/entities/connection/ui/ConnectionTypeForm/components/ConnectionOracle/index.tsx

@@ -11,15 +11,18 @@ export const ConnectionOracle = () => {
   const [isSidDisabled, setSidDisabled] = useState(false);
 
   const changeDisabledFields = useCallback(() => {
-    const serviceName = form.getFieldValue('service_name');
-    const sid = form.getFieldValue('sid');
+    const serviceName = form.getFieldValue(['connection_data', 'service_name']);
+    const sid = form.getFieldValue(['connection_data', 'sid']);
     setServiceNameDisabled(!!sid);
     setSidDisabled(!!serviceName);
   }, [form]);
 
   const handleFieldChange = () => {
     changeDisabledFields();
-    form.validateFields(['service_name', 'sid']);
+    form.validateFields([
+      ['connection_data', 'service_name'],
+      ['connection_data', 'sid'],
+    ]);
   };
 
   //* It needs to validate required fields service_name and sid correctly if they have initial values

src/entities/group/api/hooks/useGetInitialGroup/index.ts

@@ -10,5 +10,6 @@ export const useGetInitialGroup = ({ id }: GetGroupRequest): UseQueryResult<Grou
     queryKey: [GroupQueryKey.GET_GROUP, id],
     queryFn: () => groupService.getGroup({ id }),
     enabled: !!id,
+    throwOnError: false,
   });
 };

src/entities/transfer/api/types.ts

@@ -38,6 +38,7 @@ export type TransferConnectionParamFieldName = 'source_params' | 'target_params'
 
 export interface TransferStrategyParams {
   type: 'full' | 'incremental';
+  increment_by?: string;
 }
 
 interface TransferParamsHive {

src/entities/transfer/constants.ts

@@ -1,9 +1 @@
-import { prepareOptionsForSelect } from '@shared/ui';
-
-import { TransferStrategyParams } from './api';
-
-export const TRANSFER_STRATEGY_PARAMS_SELECT_OPTIONS = prepareOptionsForSelect<TransferStrategyParams['type']>({
-  data: ['full', 'incremental'],
-  renderLabel: (data) => data,
-  renderValue: (data) => data,
-});
+export const TRANSFER_INCREMENT_BY_DEFAULT = 'modified_since';

src/features/transfer/MutateTransferForm/components/StrategyParams/components/IncrementByForm/index.tsx

@@ -0,0 +1,44 @@
+import { TRANSFER_INCREMENT_BY_DEFAULT } from '@entities/transfer';
+import { ConnectionType } from '@shared/types';
+import { Form, Input } from 'antd';
+import React, { useLayoutEffect, useState } from 'react';
+
+export const IncrementByForm = () => {
+  /* useWatch takes a value from Form.Item, but useFormInstance takes one from general form state
+   * useWatch returns undefined when Form.Item has not rendered yet
+   * https://github.com/ant-design/ant-design/issues/49010
+   */
+  Form.useWatch(['source_params', 'type']);
+  const formInstance = Form.useFormInstance();
+  const sourceConnectionType = formInstance.getFieldValue(['source_params', 'type']) as ConnectionType;
+  const [isDisabled, setDisabled] = useState(false);
+
+  // change increment_by value and disabled field state depending on source connection type
+  useLayoutEffect(() => {
+    switch (sourceConnectionType) {
+      case ConnectionType.HDFS:
+      case ConnectionType.S3:
+        setDisabled(true);
+        return formInstance.setFields([
+          {
+            name: ['strategy_params', 'increment_by'],
+            value: TRANSFER_INCREMENT_BY_DEFAULT,
+            errors: [],
+          },
+        ]);
+      case ConnectionType.CLICKHOUSE:
+      case ConnectionType.HIVE:
+      case ConnectionType.MS_SQL:
+      case ConnectionType.MY_SQL:
+      case ConnectionType.ORACLE:
+      case ConnectionType.POSTGRES:
+        return setDisabled(false);
+    }
+  }, [formInstance, sourceConnectionType]);
+
+  return (
+    <Form.Item label="Increment by" name={['strategy_params', 'increment_by']} rules={[{ required: true }]}>
+      <Input size="large" disabled={isDisabled} />
+    </Form.Item>
+  );
+};

src/features/transfer/MutateTransferForm/components/StrategyParams/components/index.ts

@@ -0,0 +1 @@
+export * from './IncrementByForm';

src/features/transfer/MutateTransferForm/components/StrategyParams/constants.tsx

@@ -0,0 +1,16 @@
+import React from 'react';
+import { TransferStrategyParams } from '@entities/transfer';
+import { prepareOptionsForSelect } from '@shared/ui';
+
+import { IncrementByForm } from './components';
+
+export const TRANSFER_STRATEGY_PARAMS_SELECT_OPTIONS = prepareOptionsForSelect<TransferStrategyParams['type']>({
+  data: ['full', 'incremental'],
+  renderLabel: (data) => data,
+  renderValue: (data) => data,
+});
+
+export const INCREMENT_BY_COMPONENT = {
+  full: null,
+  incremental: <IncrementByForm />,
+};

src/features/transfer/MutateTransferForm/components/StrategyParams/index.tsx

@@ -0,0 +1,26 @@
+import React from 'react';
+import { Fieldset, Select } from '@shared/ui';
+import { Form } from 'antd';
+import { TransferStrategyParams } from '@entities/transfer';
+
+import { INCREMENT_BY_COMPONENT, TRANSFER_STRATEGY_PARAMS_SELECT_OPTIONS } from './constants';
+
+export const StrategyParams = () => {
+  const name = ['strategy_params', 'type'];
+
+  /* useWatch takes a value from Form.Item, but useFormInstance takes one from general form state
+   * useWatch returns undefined when Form.Item has not rendered yet
+   * https://github.com/ant-design/ant-design/issues/49010
+   */
+  Form.useWatch(name);
+  const strategyParamsType = Form.useFormInstance().getFieldValue(name) as TransferStrategyParams['type'];
+
+  return (
+    <Fieldset title="Strategy params">
+      <Form.Item label="Strategy params" name={name} rules={[{ required: true }]}>
+        <Select size="large" options={TRANSFER_STRATEGY_PARAMS_SELECT_OPTIONS} placeholder="Select strategy" />
+      </Form.Item>
+      {INCREMENT_BY_COMPONENT[strategyParamsType]}
+    </Fieldset>
+  );
+};