Backwards Compatibility Test

Author: MWASoftware

changelog

@@ -1,3 +1,13 @@
+FBINTF Change Log  version          (1.4-5 Build 1238) Mon, 20 Jan 2025 11:45:29 +0000
+
+1. TSQLParam.Clear now resets the SQL Type (if it was changed when setting the param)
+   and re-initialises the underlying data structure.
+
+2. TSQLParam.InternalSetString now clears the param before setting the value (also see above).
+
+3. When IStatement.Prepare is executed the underlying data structures are freed and then
+   re-created thus ensuring that there are no "left overs" from a previous use.
+
 FBINTF Change Log  version          (1.4-4 Build 1238) Mon, 20 Jan 2025 11:45:29 +0000
 
 1. FB30Blob. Removed unnecessary Firebird.IAttachment.release from close and cancel methods

client/2.5/FB25Statement.pas

@@ -907,6 +907,7 @@ procedure TIBXSQLDA.FreeXSQLDA;
     TIBXSQLVAR(Column[i]).Free;
   SetLength(FColumnList,0);
   FSize := 0;
+  FCount := 0;
 end;
 
 function TIBXSQLDA.GetStatement: IStatement;
@@ -1222,6 +1223,11 @@ procedure TFB25Statement.FreeHandle;
     FHandle := nil;
     FCursor := '';
     FPrepared := false;
+    FProcessedSQL := '';
+    if FSQLParams <> nil then
+      FSQLParams.FreeXSQLDA;
+    if FSQLRecord <> nil then
+      FSQLRecord.FreeXSQLDA;
   end;
 end;
 

client/3.0/FB30Statement.pas

@@ -1664,6 +1664,11 @@ procedure TFB30Statement.FreeHandle;
     FPrepared := false;
   end;
   FCursor := '';
+  FProcessedSQL := '';
+  if FSQLParams <> nil then
+    FSQLParams.FreeXSQLDA;
+  if FSQLRecord <> nil then
+    FSQLRecord.FreeXSQLDA;
 end;
 
 procedure TFB30Statement.InternalClose(Force: boolean);

client/FBSQLData.pas

@@ -2467,6 +2467,7 @@ procedure DoSetString;
     aScale: integer;
 begin
   CheckActive;
+  Clear;
   if IsNullable then
     IsNull := False;
   with FFirebirdClientAPI do
@@ -2588,8 +2589,57 @@ procedure TSQLParam.SetSQLType(aValue: cardinal);
 end;
 
 procedure TSQLParam.Clear;
+const
+      EmptyQuad: TISC_QUAD = (gds_quad_high:0;gds_quad_low:0);
 begin
-  IsNull := true;
+  {Restores the original SQL Type - if it was changed}
+  if CanChangeMetaData then
+    FIBXSQLVar.SetSQLType(getColMetadata.GetSQLType);
+  if IsNullable then
+    IsNull := true
+  else
+  case SQLTYPE of
+  SQL_BOOLEAN:
+      AsBoolean := false;
+
+  SQL_BLOB,
+  SQL_ARRAY,
+  SQL_QUAD:
+    AsQuad := EmptyQuad;
+
+  SQL_VARYING,
+  SQL_TEXT:
+    FIBXSQLVar.SetString('');
+
+  SQL_SHORT,
+  SQL_LONG,
+  SQL_INT64,
+  SQL_DEC_FIXED,
+  SQL_DEC16,
+  SQL_DEC34,
+  SQL_INT128,
+  SQL_D_FLOAT,
+  SQL_DOUBLE,
+  SQL_FLOAT:
+    SetAsNumeric(IntToNumeric(0));
+
+  SQL_TIMESTAMP:
+        SetAsDateTime(0);
+
+  SQL_TYPE_DATE:
+        SetAsDate(0);
+
+  SQL_TYPE_TIME:
+        SetAsTime(0);
+
+  SQL_TIMESTAMP_TZ,
+  SQL_TIMESTAMP_TZ_EX:
+        SetAsDateTime(0,'');
+
+  SQL_TIME_TZ,
+  SQL_TIME_TZ_EX:
+        SetAsTime(0,0,'');
+  end;
 end;
 
 function TSQLParam.CanChangeMetaData: boolean;

testsuite/testsuite.lpi

@@ -28,7 +28,7 @@
     </PublishOptions>
     <RunParams>
       <local>
-        <CommandLineParams Value="-t 10"/>
+        <CommandLineParams Value="-t 21"/>
       </local>
       <environment>
         <UserOverrides Count="3">
@@ -41,7 +41,7 @@
       <Modes Count="1">
         <Mode0 Name="default">
           <local>
-            <CommandLineParams Value="-t 10"/>
+            <CommandLineParams Value="-t 21"/>
           </local>
           <environment>
             <UserOverrides Count="3">