Fix checkinstall function, selecting multiple installed packages should now give the option to uninstall them

Author: AdrianTM

debian/changelog

@@ -1,3 +1,10 @@
+mx-packageinstaller (25.7) mx; urgency=medium
+
+  * Fix checkinstall function, selecting multiple installed packages
+    should give the option to uninstall them
+
+ -- Adrian <[email protected]>  Fri, 11 Jul 2025 12:13:33 -0400
+
 mx-packageinstaller (25.6.01) mx; urgency=medium
 
   * Fix localization

mainwindow.cpp

@@ -1936,12 +1936,22 @@ QString MainWindow::getVersion(const QString &name) const
 // Return true if all the packages listed are installed
 bool MainWindow::checkInstalled(const QVariant &names) const
 {
-    const QStringList name_list
-        = names.canConvert<QString>() ? names.toString().split('\n', Qt::SkipEmptyParts) : names.toStringList();
+    QStringList name_list;
+    if (names.canConvert<QStringList>()) {
+        name_list = names.toStringList();
+    } else if (names.canConvert<QString>()) {
+        name_list = names.toString().split('\n', Qt::SkipEmptyParts);
+    }
 
-    return !name_list.isEmpty() && std::all_of(name_list.cbegin(), name_list.cend(), [this](const QString &name) {
-        return installedPackages.contains(name.trimmed());
-    });
+    if (name_list.isEmpty()) {
+        return false;
+    }
+    for (const QString &name : name_list) {
+        if (!installedPackages.contains(name.trimmed())) {
+            return false;
+        }
+    }
+    return true;
 }
 
 // Return true if all the items in the list are upgradable