Skip to content

Commit 16dc9c9

Browse files
authored
Merge pull request #370 from Maaack/credits-fixes
Minor Credits class fixes
2 parents 310bc72 + 723f233 commit 16dc9c9

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,2 @@
11
class_name Credits
22
extends Control
3-
4-
signal end_reached

addons/maaacks_game_template/base/scenes/credits/credits_label.gd

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ func regex_replace_imgs(credits:String) -> String:
4444
else:
4545
replace_string = "[img]" + replace_string
4646
regex.compile(match_string)
47-
regex.get_group_count()
4847
return regex.sub(credits, replace_string, true)
4948

5049
func regex_replace_urls(credits:String) -> String:

addons/maaacks_game_template/base/scenes/credits/scrolling_credits.gd

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
class_name ScrollingCredits
22
extends Credits
33

4+
signal end_reached
5+
46
@onready var header_space : Control = %HeaderSpace
57
@onready var footer_space : Control = %FooterSpace
68
@onready var credits_label : Control = %CreditsLabel

0 commit comments

Comments
 (0)