Merge pull request #397 from Maaack/fix-scrollable-credits

Fixes scrollable credits responsiveness to up and down inputs

Author: Maaack

addons/maaacks_game_template/examples/scenes/credits/scrollable_credits.gd

@@ -3,7 +3,9 @@ extends Control
 
 @onready var credits_label : RichTextLabel = %CreditsLabel
 
-@export var input_scroll_speed : float = 400.0
+@export var input_scroll_speed : float = 10.0
+
+var _line_number : float = 0
 
 func _on_visibility_changed() -> void:
 	if visible:
@@ -17,5 +19,11 @@ func _process(delta : float) -> void:
 	if Engine.is_editor_hint() or not visible:
 		return
 	var input_axis = Input.get_axis("ui_up", "ui_down")
-	if input_axis != 0:
-		credits_label.get_v_scroll_bar().value += input_axis * delta * input_scroll_speed
+	if abs(input_axis) > 0.5:
+		_line_number += input_axis * delta * input_scroll_speed
+		var max_lines = credits_label.get_line_count() - credits_label.get_visible_line_count()
+		if _line_number < 0:
+			_line_number = 0
+		if _line_number > max_lines:
+			_line_number = max_lines
+		credits_label.scroll_to_line(round(_line_number))

scenes/credits/scrollable_credits.gd

@@ -3,7 +3,9 @@ extends Control
 
 @onready var credits_label : RichTextLabel = %CreditsLabel
 
-@export var input_scroll_speed : float = 400.0
+@export var input_scroll_speed : float = 10.0
+
+var _line_number : float = 0
 
 func _on_visibility_changed() -> void:
 	if visible:
@@ -17,5 +19,11 @@ func _process(delta : float) -> void:
 	if Engine.is_editor_hint() or not visible:
 		return
 	var input_axis = Input.get_axis("ui_up", "ui_down")
-	if input_axis != 0:
-		credits_label.get_v_scroll_bar().value += input_axis * delta * input_scroll_speed
+	if abs(input_axis) > 0.5:
+		_line_number += input_axis * delta * input_scroll_speed
+		var max_lines = credits_label.get_line_count() - credits_label.get_visible_line_count()
+		if _line_number < 0:
+			_line_number = 0
+		if _line_number > max_lines:
+			_line_number = max_lines
+		credits_label.scroll_to_line(round(_line_number))