docker-action fix/apple notarization fix/windows firewall prompt fix

Author: ensaremirerol

.github/workflows/build-docker-image.yml

@@ -6,39 +6,46 @@ on:
       - '[0-9]+.[0-9]+.[0-9]+'
 
 env:
-  VERSION: ''
   REGISTRY: ghcr.io
-  IMAGE_NAME: 'rdfcraft'
+  IMAGE_NAME: rdfcraft
 
 jobs:
   docker:
     permissions:
-      packages: write
       contents: read
+      packages: write
     runs-on: ubuntu-latest
     steps:
-      - name: extract version
-        id: extract_version
-        run: |
-          echo "VERSION=$(echo $GITHUB_REF | cut -d / -f 3)" >> "${GITHUB_ENV}"
       - name: Checkout
         uses: actions/checkout@v4
+
+      # Ensure lowercase owner for GHCR path
+      - name: Compute owner and version
+        run: |
+          echo "OWNER=${GITHUB_REPOSITORY_OWNER@L}" >> "$GITHUB_ENV"
+          echo "VERSION=${GITHUB_REF_NAME}" >> "$GITHUB_ENV"
+
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3
+
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
-      - name: Login to Docker Hub
+
+      - name: Login to GHCR
         uses: docker/login-action@v3
         with:
           registry: ${{ env.REGISTRY }}
-          username: ${{ github.actor }}
+          username: ${{ env.OWNER }}
           password: ${{ secrets.GITHUB_TOKEN }}
+
       - name: Build and push
         uses: docker/build-push-action@v5
         with:
           context: .
           platforms: linux/amd64,linux/arm64
           push: true
+          # Set to true if you want provenance; if you still hit errors, try false
+          provenance: false
           tags: |
-            ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ env.VERSION }}
-            ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest
+            ${{ env.REGISTRY }}/${{ env.OWNER }}/${{ env.IMAGE_NAME }}:${{ env.VERSION }}
+            ${{ env.REGISTRY }}/${{ env.OWNER }}/${{ env.IMAGE_NAME }}:latest

.github/workflows/build.yml

@@ -74,10 +74,10 @@ jobs:
           ./scripts/mac/notarize-bundle.sh
 
       # Zip the RDFCraft.app so it remains a folder after download
-      - name: Create ZIP from .app
+      - name: Rename the zip file
         run: |
           cd dist
-          zip -r RDFCraft-mac.zip RDFCraft.app
+          mv RDFCraft.zip RDFCraft-mac.zip
 
       - name: Upload Mac Artifact
         uses: actions/upload-artifact@v4

README.MD

@@ -40,18 +40,6 @@ From [Releases](https://github.com/MaastrichtU-IDS/RDFCraft/releases) page,
 download the latest release for your OS and extract the contents if it is
 compressed. Run the executable and you are good to go.
 
-> [!WARNING]
->
-> On macOS, because app is not notarized by Apple, you need to run following
-> command to bypass the gatekeeper:
->
-> ```bash
-> xattr -rd com.apple.quarantine </path/to/RDFCraft.app>
-> ```
->
-> More information about gatekeeper can be found
-> [here](https://support.apple.com/en-us/HT202491).
-
 ### With Docker 🐳
 
 Build the Docker Image:

docs/README.md

@@ -40,18 +40,6 @@ From [Releases](https://github.com/MaastrichtU-IDS/RDFCraft/releases) page,
 download the latest release for your OS and extract the contents if it is
 compressed. Run the executable and you are good to go.
 
-> [!WARNING]
->
-> On macOS, because app is not notarized by Apple, you need to run following
-> command to bypass the gatekeeper:
->
-> ```bash
-> xattr -rd com.apple.quarantine </path/to/RDFCraft.app>
-> ```
->
-> More information about gatekeeper can be found
-> [here](https://support.apple.com/en-us/HT202491).
-
 ## Getting Started 🚦
 
 You can find a detailed guide on how to use RDFCraft in the

main.py

@@ -84,7 +84,8 @@ def get_free_port():
 def start_fastapi():
     import uvicorn
 
-    uvicorn.run(app, host="0.0.0.0", port=port, log_config=None)
+    # DO NOT Serve on 0.0.0.0, Windows will show firewall prompt on every launch
+    uvicorn.run(app, host="127.0.0.1", port=port, log_config=None)
 
 
 def on_closing():
@@ -104,7 +105,7 @@ def on_closing():
         # Create window
         window = webview.create_window(
             "RDFCraft",
-            f"http://localhost:{port}",
+            f"http://127.0.0.1:{port}",
             min_size=(800, 600),
             resizable=True,
         )