fixed comments

Author: oflipman

src/ResourceManager/Kusto/Commands.Kusto.Test/ScenarioTests/Common.ps1

@@ -73,15 +73,6 @@ function Get-Cluster-Resource-Type
 	return "Microsoft.Kusto/Clusters"
 }
 
-<#
-.SYNOPSIS
-Gets a resource group Location for testing.
-#>
-function Get-RG-Location
-{
-	return Get-Location
-}
-
 <#
 .SYNOPSIS
 Gets a cluster resource id
@@ -170,7 +161,6 @@ Gets a the database does not exist message
 function Get-Database-Not-Exist-Message
 {
 	Param([string]$DatabaseName)
-#	return "$DatabaseName' is not found"
 	return "$DatabaseName' is not found"
 }
 

src/ResourceManager/Kusto/Commands.Kusto/Az.Kusto.psd1

@@ -120,9 +120,6 @@ PrivateData = @{
         # ReleaseNotes of this module
         ReleaseNotes = 'Initial version of the Kusto powershell interface'
 
-        # Prerelease string of this module
-        Prerelease = 'preview'
-
         # Flag to indicate whether the module requires explicit user acceptance for install/update
         # RequireLicenseAcceptance = $false
 

src/ResourceManager/Kusto/Commands.Kusto/Commands/GetAzureRmKustoDatabase.cs

@@ -58,7 +58,6 @@ public class GetAzureRmKustoDatabase : KustoCmdletBase
         [Parameter(
             ParameterSetName = ObjectParameterSet,
             Mandatory = true,
-            Position = 2,
             ValueFromPipeline = true,
             HelpMessage = "Kusto cluster object.")]
         [ValidateNotNullOrEmpty]

src/ResourceManager/Kusto/Commands.Kusto/Commands/NewAzureRmKustoDatabase.cs

@@ -54,12 +54,12 @@ public class NewAzureRmKustoDatabase : KustoCmdletBase
 
         [Parameter(
             Mandatory = true,
-            HelpMessage = "the amount of days.")]
+            HelpMessage = "The number of days data should be kept before it stops being accessible to queries.")]
         public int SoftDeletePeriodInDays { get; set; }
 
         [Parameter(
             Mandatory = true,
-            HelpMessage = "Azure region where the cluster exists.")]
+            HelpMessage = "The number of days of data that should be kept in cache for fast queries.")]
         public int HotCachePeriodInDays { get; set; }
 
         [Parameter(

src/ResourceManager/Kusto/Commands.Kusto/Commands/RemoveAzureRmKustoDatabase.cs

@@ -48,6 +48,7 @@ public class RemoveAzureRmKustoDatabase : KustoCmdletBase
 
         [Parameter(
             ParameterSetName = CmdletParametersSet,
+            Position = 2,
             Mandatory = true,
             HelpMessage = "Name of database to be removed.")]
         [ValidateNotNullOrEmpty]

src/ResourceManager/Kusto/Commands.Kusto/Commands/ResumeAzureRmKustoCluster.cs

@@ -21,7 +21,7 @@
 
 namespace Microsoft.Azure.Commands.Kusto.Commands
 {
-    [Cmdlet("Resume", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "KustoCluster", DefaultParameterSetName = ResourceIdParameterSet, SupportsShouldProcess = true), OutputType(typeof(bool))]
+    [Cmdlet("Resume", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "KustoCluster", DefaultParameterSetName = CmdletParametersSet, SupportsShouldProcess = true), OutputType(typeof(bool))]
     public class ResumeAzureRmKustoCluster: KustoCmdletBase
     {
         protected const string CmdletParametersSet = "ByNameAndResourceGroup";

src/ResourceManager/Kusto/Commands.Kusto/Commands/TestAzureRmKustoClusterName.cs

@@ -47,7 +47,7 @@ public override void ExecuteCmdlet()
            string clusterName = Name;
            EnsureClusterSpecified(clusterName);
 
-            var result = KustoClient.CheckClusterNAmeAvailability(clusterName, location);
+            var result = KustoClient.CheckClusterNameAvailability(clusterName, location);
             WriteObject(result);
         }
     }

src/ResourceManager/Kusto/Commands.Kusto/Commands/UpdateAzureRmKustoCluster.cs

@@ -49,7 +49,7 @@ public class UpdateAzureRmKustoCluster : KustoCmdletBase
         public string Name { get; set; }
 
         [Parameter(
-            Mandatory = true,
+            Mandatory = false,
             HelpMessage = "Name of the Sku used to create the cluster")]
         [ValidateNotNullOrEmpty]
         [PSArgumentCompleter("KC8", "KC16", "KS8", "KS16", "L8", "L16", "D14_v2", "D13_v2")]
@@ -84,7 +84,8 @@ public override void ExecuteCmdlet()
             string clusterName = Name;
             string resourceGroupName = ResourceGroupName;
             string location = null;
-
+            string skuName = null;
+            
             if (!string.IsNullOrEmpty(ResourceId))
             {
                 KustoUtils.GetResourceGroupNameAndClusterNameFromClusterId(ResourceId, out resourceGroupName, out clusterName);
@@ -105,6 +106,7 @@ public override void ExecuteCmdlet()
                     }
 
                     location = cluster.Location;
+                    skuName = string.IsNullOrEmpty(SkuName) ? cluster.Sku: SkuName;
                 }
                 catch (CloudException ex)
                 {
@@ -125,7 +127,7 @@ public override void ExecuteCmdlet()
                     }
                 }
 
-                var updatedCluster = KustoClient.CreateOrUpdateCluster(resourceGroupName, clusterName, location, SkuName);
+                var updatedCluster = KustoClient.CreateOrUpdateCluster(resourceGroupName, clusterName, location, skuName);
                 WriteObject(updatedCluster);
             }
         }

src/ResourceManager/Kusto/Commands.Kusto/Commands/UpdateAzureRmKustoDatabase.cs

@@ -58,16 +58,14 @@ public class UpdateAzureRmKustoDatabase : KustoCmdletBase
         public string Name { get; set; }
 
         [Parameter(
-            ValueFromPipelineByPropertyName = true,
-            Mandatory = true,
+            Mandatory = false,
             HelpMessage = "The number of days that data should be kept before it stops being accessible to queries")]
-        public int SoftDeletePeriodInDays { get; set; }
+        public int? SoftDeletePeriodInDays { get; set; }
 
         [Parameter(
-            ValueFromPipelineByPropertyName = true,
-            Mandatory = true,
+            Mandatory = false,
             HelpMessage = "The number of days that data should be kept in cache for fast queries")]
-        public int HotCachePeriodInDays { get; set; }
+        public int? HotCachePeriodInDays { get; set; }
 
         [Parameter(
             ParameterSetName = ResourceIdParameterSet,
@@ -93,6 +91,8 @@ public override void ExecuteCmdlet()
             string clusterName = ClusterName;
             string resourceGroupName = ResourceGroupName;
             string location = null;
+            int hotCachePeriodInDays = 0;
+            int softRetentionPeriodInDays = 0;
 
             if (!string.IsNullOrEmpty(ResourceId))
             {
@@ -116,6 +116,8 @@ public override void ExecuteCmdlet()
                     }
 
                     location = database.Location;
+                    hotCachePeriodInDays = HotCachePeriodInDays ?? database.HotCachePeriodInDays.GetValueOrDefault();
+                    softRetentionPeriodInDays = SoftDeletePeriodInDays ?? database.SoftDeletePeriodInDays;
                 }
                 catch (CloudException ex)
                 {
@@ -135,12 +137,11 @@ public override void ExecuteCmdlet()
                         throw;
                     }
                 }
-
-                var updatedDatabase = KustoClient.CreateOrUpdateDatabase(resourceGroupName, clusterName, databaseName, HotCachePeriodInDays, SoftDeletePeriodInDays, location);
+                
+                var updatedDatabase = KustoClient.CreateOrUpdateDatabase(resourceGroupName, clusterName, databaseName, hotCachePeriodInDays, softRetentionPeriodInDays, location);
                 WriteObject(updatedDatabase);
             }
         }
 
     }
 }
-

src/ResourceManager/Kusto/Commands.Kusto/Models/KustoClient.cs

@@ -54,7 +54,7 @@ public KustoClient()
 
         #region Cluster Related Operations
 
-        public CheckNameResult CheckClusterNAmeAvailability(string clusterName, string location)
+        public CheckNameResult CheckClusterNameAvailability(string clusterName, string location)
         {
             return _client.Clusters.CheckNameAvailability(location, new ClusterCheckNameRequest(clusterName));
         }
@@ -226,7 +226,7 @@ public PSKustoDatabase CreateOrUpdateDatabase(string resourceGroupName,
                     databaseName,
                     new Database()
                     {
-                       HotCachePeriodInDays = hotCachePeriodInDays,
+                        HotCachePeriodInDays = hotCachePeriodInDays,
                         SoftDeletePeriodInDays = softDeletePeriodInDays,
                         Location = location
                     });