-
Notifications
You must be signed in to change notification settings - Fork 18
Using USE_THREADS & NUM_THREADS while building openblas for win arm64 #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR @Akash9824. It would be useful to explain what issue you are having without this change, and why the choices you are introducing here are the correct ones (e.g., why 24 threads, is that the same as on x86-64 or not). |
Fixes #213 |
Apologies for not describing the issue earlier. I used 24 threads, as the same configuration is being used in x86-64. |
macOS failures not related. Any idea why arm build is failing? It seems something changed with the compiler since the last successful build in July. |
In #216 the flang build fails on windows-arm64 with
I am trying the scipy recipe with llvm 20 |
I observed the same error with VS 2022 Flang. I don't think it's due to the flags, I'm able to build successfully using LLVM 20+ |
What fortran compiler are you using? |
minor typo.. not clang its flang. |
ahh, maybe the image now has flang from visual studio and is is being found before the llvm one? |
@Akash9824 you are using
|
Preferring LLVM flang seems to have fixed the problem. @Akash9824 could you download the appropriate 64-bit artifact and check that indeed it uses all the threads on your machine? Copy the DLL from the zip file over the one in your current numpy.libs directory, it should be renamed to |
Yep, it seems to be working, I can see all cores being utilized(seeing num of working threads equals to num of cores). I'm doing dot matrix multiplication. ![]() |
I will try to get #216 to pass, and in any case upload updated wheels to PyPI with this fix soon. Then I can submit PRs to numpy (and scipy?) to use it. |
No description provided.