Bump Visualize to v1.8 #4009
Open
Bump Visualize to v1.8 #4009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since BootSideMenu only supports Bootstrap 3, we need to trick it: * Use both data-toggle (Bootstrap v3) and data-bs-toggle (Bootstrap v5) attributes. * Use fontawesome fonts instead of glyphicons since they've been removed from Bootstrap. Also bundle w/ webpack
With the bump from v8.5.1 -> v15.8.1, we don't need the custom css anymore.
Needed a lot of new let's and const's. Also, now we can remove d3
Also, we can remove our vendored three.js
We now bundle most of the javascript code using webpack. Also, bump from Boostrap 3 -> Bootstrap 5 support.
|
Here are the examples after the update: @pzinn: Would you be willing to take a look at this when you get a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major change is that most of the Javascript code is now bundled using webpack. We also bump Bootstrap from 3 to 5, closing #3989.