Merge branch 'master' of https://github.com/MachDatum/ThingConnect.Pulse into endpoin-loadingstate

Author: abishekve

ThingConnect.Pulse.Server/Controllers/AuthController.cs

@@ -29,8 +29,9 @@ public AuthController(
     }
 
     /// <summary>
-    /// User login - creates authentication cookie
+    /// User login - creates authentication cookie.
     /// </summary>
+    /// <returns><placeholder>A <see cref="Task"/> representing the asynchronous operation.</placeholder></returns>
     [HttpPost("login")]
     public async Task<ActionResult<UserInfoDto>> LoginAsync([FromBody] LoginRequestDto request)
     {
@@ -88,8 +89,9 @@ public async Task<ActionResult<UserInfoDto>> LoginAsync([FromBody] LoginRequestD
     }
 
     /// <summary>
-    /// Initial user registration - only allows admin creation if no users exist
+    /// Initial user registration - only allows admin creation if no users exist.
     /// </summary>
+    /// <returns><placeholder>A <see cref="Task"/> representing the asynchronous operation.</placeholder></returns>
     [HttpPost("register")]
     public async Task<ActionResult<UserInfoDto>> RegisterAsync([FromBody] RegisterRequestDto request)
     {
@@ -124,7 +126,7 @@ public async Task<ActionResult<UserInfoDto>> RegisterAsync([FromBody] RegisterRe
 
             // Sign in the user immediately after successful registration
             await _signInManager.SignInAsync(user, isPersistent: true);
-            
+
             // Update last login time since we just signed them in
             user.LastLoginAt = DateTimeOffset.UtcNow;
             await _userManager.UpdateAsync(user);
@@ -150,8 +152,9 @@ public async Task<ActionResult<UserInfoDto>> RegisterAsync([FromBody] RegisterRe
     }
 
     /// <summary>
-    /// Check if initial setup is needed
+    /// Check if initial setup is needed.
     /// </summary>
+    /// <returns></returns>
     [HttpGet("setup-required")]
     public ActionResult<bool> IsSetupRequired()
     {
@@ -168,8 +171,9 @@ public ActionResult<bool> IsSetupRequired()
     }
 
     /// <summary>
-    /// Get current user session information
+    /// Get current user session information.
     /// </summary>
+    /// <returns><placeholder>A <see cref="Task"/> representing the asynchronous operation.</placeholder></returns>
     [HttpGet("session")]
     [Authorize]
     public async Task<ActionResult<UserInfoDto>> GetSessionAsync()
@@ -201,8 +205,9 @@ public async Task<ActionResult<UserInfoDto>> GetSessionAsync()
     }
 
     /// <summary>
-    /// Change user's own password
+    /// Change user's own password.
     /// </summary>
+    /// <returns><placeholder>A <see cref="Task"/> representing the asynchronous operation.</placeholder></returns>
     [HttpPost("change-password")]
     [Authorize]
     public async Task<IActionResult> ChangePasswordAsync([FromBody] ChangePasswordDto request)
@@ -237,8 +242,9 @@ public async Task<IActionResult> ChangePasswordAsync([FromBody] ChangePasswordDt
     }
 
     /// <summary>
-    /// Logout - removes authentication cookie
+    /// Logout - removes authentication cookie.
     /// </summary>
+    /// <returns><placeholder>A <see cref="Task"/> representing the asynchronous operation.</placeholder></returns>
     [HttpPost("logout")]
     [Authorize]
     public async Task<IActionResult> LogoutAsync()
@@ -263,8 +269,9 @@ public async Task<IActionResult> LogoutAsync()
     }
 
     /// <summary>
-    /// Save telemetry consent settings during onboarding
+    /// Save telemetry consent settings during onboarding.
     /// </summary>
+    /// <returns><placeholder>A <see cref="Task"/> representing the asynchronous operation.</placeholder></returns>
     [HttpPost("telemetry-consent")]
     public async Task<IActionResult> SaveTelemetryConsentAsync([FromBody] TelemetryConsentDto request)
     {
@@ -288,8 +295,9 @@ public async Task<IActionResult> SaveTelemetryConsentAsync([FromBody] TelemetryC
     }
 
     /// <summary>
-    /// Get current telemetry consent settings
+    /// Get current telemetry consent settings.
     /// </summary>
+    /// <returns><placeholder>A <see cref="Task"/> representing the asynchronous operation.</placeholder></returns>
     [HttpGet("telemetry-consent")]
     public async Task<ActionResult<TelemetryConsentDto>> GetTelemetryConsentAsync()
     {
@@ -310,4 +318,4 @@ public async Task<ActionResult<TelemetryConsentDto>> GetTelemetryConsentAsync()
             return StatusCode(500, new { message = "Internal server error" });
         }
     }
-}
+}

ThingConnect.Pulse.Server/Controllers/ConfigurationController.cs

@@ -18,10 +18,10 @@ public ConfigurationController(IConfigurationService configurationService)
     }
 
     /// <summary>
-    /// Validate and apply YAML configuration
+    /// Validate and apply YAML configuration.
     /// </summary>
-    /// <param name="dryRun">If true, only validate and preview changes without applying</param>
-    /// <returns>Apply result with counts of changes made or preview of changes</returns>
+    /// <param name="dryRun">If true, only validate and preview changes without applying.</param>
+    /// <returns>Apply result with counts of changes made or preview of changes.</returns>
     [HttpPost("apply")]
     [Authorize(Roles = UserRoles.Administrator)]
     public async Task<ActionResult<ApplyResultDto>> ApplyAsync([FromQuery] bool dryRun = false)
@@ -38,7 +38,7 @@ public async Task<ActionResult<ApplyResultDto>> ApplyAsync([FromQuery] bool dryR
                     Message = "YAML content is required",
                     Errors = new List<ValidationError>
                     {
-                        new() { Path = "", Message = "YAML content cannot be empty", Value = null }
+                        new() { Path = string.Empty, Message = "YAML content cannot be empty", Value = null }
                     }
                 });
             }
@@ -69,7 +69,7 @@ public async Task<ActionResult<ApplyResultDto>> ApplyAsync([FromQuery] bool dryR
                 Message = ex.Message,
                 Errors = new List<ValidationError>
                 {
-                    new() { Path = "", Message = ex.Message, Value = null }
+                    new() { Path = string.Empty, Message = ex.Message, Value = null }
                 }
             });
         }
@@ -80,16 +80,16 @@ public async Task<ActionResult<ApplyResultDto>> ApplyAsync([FromQuery] bool dryR
                 Message = "Internal server error while applying configuration",
                 Errors = new List<ValidationError>
                 {
-                    new() { Path = "", Message = ex.Message, Value = null }
+                    new() { Path = string.Empty, Message = ex.Message, Value = null }
                 }
             });
         }
     }
 
     /// <summary>
-    /// List all configuration versions
+    /// List all configuration versions.
     /// </summary>
-    /// <returns>List of configuration versions ordered by applied timestamp descending</returns>
+    /// <returns>List of configuration versions ordered by applied timestamp descending.</returns>
     [HttpGet("versions")]
     [Authorize]
     public async Task<ActionResult<List<ConfigurationVersionDto>>> GetVersionsAsync()
@@ -106,10 +106,10 @@ public async Task<ActionResult<List<ConfigurationVersionDto>>> GetVersionsAsync(
     }
 
     /// <summary>
-    /// Download a specific configuration version as YAML
+    /// Download a specific configuration version as YAML.
     /// </summary>
-    /// <param name="id">Configuration version ID</param>
-    /// <returns>Plain YAML content</returns>
+    /// <param name="id">Configuration version ID.</param>
+    /// <returns>Plain YAML content.</returns>
     [HttpGet("versions/{id}")]
     [Authorize]
     public async Task<ActionResult> GetVersionAsync(string id)
@@ -131,9 +131,9 @@ public async Task<ActionResult> GetVersionAsync(string id)
     }
 
     /// <summary>
-    /// Get the current active configuration as YAML
+    /// Get the current active configuration as YAML.
     /// </summary>
-    /// <returns>Plain YAML content of the active configuration</returns>
+    /// <returns>Plain YAML content of the active configuration.</returns>
     [HttpGet("current")]
     [Authorize]
     public async Task<ActionResult> GetCurrentAsync()

ThingConnect.Pulse.Server/Controllers/HistoryController.cs

@@ -20,13 +20,13 @@ public HistoryController(IHistoryService historyService, ILogger<HistoryControll
     }
 
     /// <summary>
-    /// Get historical data for a specific endpoint
+    /// Get historical data for a specific endpoint.
     /// </summary>
-    /// <param name="id">Endpoint ID</param>
-    /// <param name="from">Start time (ISO 8601 format)</param>
-    /// <param name="to">End time (ISO 8601 format)</param>
-    /// <param name="bucket">Data bucket type: raw, 15m, or daily</param>
-    /// <returns>Historical data for the endpoint</returns>
+    /// <param name="id">Endpoint ID.</param>
+    /// <param name="from">Start time (ISO 8601 format).</param>
+    /// <param name="to">End time (ISO 8601 format).</param>
+    /// <param name="bucket">Data bucket type: raw, 15m, or daily.</param>
+    /// <returns>Historical data for the endpoint.</returns>
     [HttpGet("endpoint/{id}")]
     public async Task<ActionResult<HistoryResponseDto>> GetEndpointHistoryAsync(
         [FromRoute] Guid id,
@@ -88,4 +88,4 @@ public async Task<ActionResult<HistoryResponseDto>> GetEndpointHistoryAsync(
             return StatusCode(500, new { message = "Internal server error while retrieving endpoint history" });
         }
     }
-}
+}

ThingConnect.Pulse.Server/Controllers/StatusController.cs

@@ -20,11 +20,11 @@ public StatusController(IStatusService statusService, ILogger<StatusController>
     }
 
     /// <summary>
-    /// Get paged live status feed for all endpoints
+    /// Get paged live status feed for all endpoints.
     /// </summary>
-    /// <param name="group">Optional group ID filter</param>
-    /// <param name="search">Optional search string (matches name or host)</param>
-    /// <returns>Paged list of endpoint status with sparkline data</returns>
+    /// <param name="group">Optional group ID filter.</param>
+    /// <param name="search">Optional search string (matches name or host).</param>
+    /// <returns>Paged list of endpoint status with sparkline data.</returns>
     [HttpGet("live")]
     public async Task<ActionResult<LiveStatusItemDto>> GetLiveStatusAsync(
         [FromQuery] string? group = null,
@@ -35,10 +35,10 @@ public async Task<ActionResult<LiveStatusItemDto>> GetLiveStatusAsync(
             _logger.LogInformation("Getting live status - group: {Group}, search: {Search}, page: {Page}, pageSize: {PageSize}",
                 group, search);
 
-            var result = await _statusService.GetLiveStatusAsync(group, search);
-    
-        return Ok(new { items = result });
-    }
+            List<LiveStatusItemDto> result = await _statusService.GetLiveStatusAsync(group, search);
+
+            return Ok(new { items = result });
+        }
         catch (Exception ex)
         {
             _logger.LogError(ex, "Error getting live status");

ThingConnect.Pulse.Server/Controllers/UserManagementController.cs

@@ -24,8 +24,9 @@ public UserManagementController(
     }
 
     /// <summary>
-    /// Get all users with pagination
+    /// Get all users with pagination.
     /// </summary>
+    /// <returns><placeholder>A <see cref="Task"/> representing the asynchronous operation.</placeholder></returns>
     [HttpGet]
     public async Task<ActionResult<PagedResult<UserInfoDto>>> GetUsersAsync(
         [FromQuery] int page = 1,
@@ -36,8 +37,15 @@ public async Task<ActionResult<PagedResult<UserInfoDto>>> GetUsersAsync(
     {
         try
         {
-            if (page < 1) page = 1;
-            if (pageSize < 1 || pageSize > 100) pageSize = 20;
+            if (page < 1)
+            {
+                page = 1;
+            }
+
+            if (pageSize < 1 || pageSize > 100)
+            {
+                pageSize = 20;
+            }
 
             IQueryable<ApplicationUser> query = _userManager.Users.AsQueryable();
 
@@ -97,8 +105,9 @@ public async Task<ActionResult<PagedResult<UserInfoDto>>> GetUsersAsync(
     }
 
     /// <summary>
-    /// Get user by ID
+    /// Get user by ID.
     /// </summary>
+    /// <returns><placeholder>A <see cref="Task"/> representing the asynchronous operation.</placeholder></returns>
     [HttpGet("{id}")]
     public async Task<ActionResult<UserInfoDto>> GetUserByIdAsync(string id)
     {
@@ -129,8 +138,9 @@ public async Task<ActionResult<UserInfoDto>> GetUserByIdAsync(string id)
     }
 
     /// <summary>
-    /// Create a new user
+    /// Create a new user.
     /// </summary>
+    /// <returns><placeholder>A <see cref="Task"/> representing the asynchronous operation.</placeholder></returns>
     [HttpPost]
     public async Task<ActionResult<UserInfoDto>> CreateUserAsync([FromBody] CreateUserDto request)
     {
@@ -196,8 +206,9 @@ public async Task<ActionResult<UserInfoDto>> CreateUserAsync([FromBody] CreateUs
     }
 
     /// <summary>
-    /// Update user details
+    /// Update user details.
     /// </summary>
+    /// <returns><placeholder>A <see cref="Task"/> representing the asynchronous operation.</placeholder></returns>
     [HttpPut("{id}")]
     public async Task<ActionResult<UserInfoDto>> UpdateUserAsync(string id, [FromBody] UpdateUserDto request)
     {
@@ -285,8 +296,9 @@ public async Task<ActionResult<UserInfoDto>> UpdateUserAsync(string id, [FromBod
     }
 
     /// <summary>
-    /// Change user role
+    /// Change user role.
     /// </summary>
+    /// <returns><placeholder>A <see cref="Task"/> representing the asynchronous operation.</placeholder></returns>
     [HttpPut("{id}/role")]
     public async Task<ActionResult<UserInfoDto>> ChangeUserRoleAsync(string id, [FromBody] ChangeRoleDto request)
     {
@@ -348,8 +360,9 @@ public async Task<ActionResult<UserInfoDto>> ChangeUserRoleAsync(string id, [Fro
     }
 
     /// <summary>
-    /// Reset user password (admin only)
+    /// Reset user password (admin only).
     /// </summary>
+    /// <returns><placeholder>A <see cref="Task"/> representing the asynchronous operation.</placeholder></returns>
     [HttpPost("{id}/reset-password")]
     public async Task<IActionResult> ResetPasswordAsync(string id, [FromBody] ResetPasswordDto request)
     {
@@ -389,8 +402,9 @@ public async Task<IActionResult> ResetPasswordAsync(string id, [FromBody] ResetP
     }
 
     /// <summary>
-    /// Delete user (soft delete - deactivate)
+    /// Delete user (soft delete - deactivate).
     /// </summary>
+    /// <returns><placeholder>A <see cref="Task"/> representing the asynchronous operation.</placeholder></returns>
     [HttpDelete("{id}")]
     public async Task<IActionResult> DeleteUserAsync(string id)
     {
@@ -451,4 +465,4 @@ public sealed class PagedResult<T>
     public int PageSize { get; set; }
     public int TotalCount { get; set; }
     public int TotalPages { get; set; }
-}
+}

ThingConnect.Pulse.Server/Data/ApplicationUser.cs

@@ -17,4 +17,4 @@ public static class UserRoles
     public const string User = "User";
 
     public static readonly string[] AllRoles = { Administrator, User };
-}
+}

ThingConnect.Pulse.Server/Data/Entities.cs

@@ -63,13 +63,13 @@ public sealed class Outage
     public string? LastError { get; set; }
 
     /// <summary>
-    /// Timestamp when monitoring was lost during this outage (service downtime).
+    /// Gets or sets timestamp when monitoring was lost during this outage (service downtime).
     /// If not null, indicates outage duration may be inaccurate due to monitoring gap.
     /// </summary>
     public long? MonitoringStoppedTs { get; set; }
 
     /// <summary>
-    /// True if this outage spans a period when monitoring service was unavailable.
+    /// Gets or sets a value indicating whether true if this outage spans a period when monitoring service was unavailable.
     /// Indicates uncertainty in the actual endpoint availability during that time.
     /// </summary>
     public bool HasMonitoringGap { get; set; }
@@ -119,6 +119,12 @@ public sealed class MonitoringSession
     public long Id { get; set; }
     public long StartedTs { get; set; }
     public long? EndedTs { get; set; }
+
+    /// <summary>
+    /// Gets or sets timestamp of last monitoring activity (periodic heartbeat).
+    /// Updated regularly during monitoring to provide accurate gap detection.
+    /// </summary>
+    public long? LastActivityTs { get; set; }
     public string? ShutdownReason { get; set; }
     public string? Version { get; set; }
 }

ThingConnect.Pulse.Server/Data/PulseDbContext.cs

@@ -16,7 +16,8 @@ public sealed class PulseDbContext : IdentityDbContext<ApplicationUser>
     public DbSet<ConfigVersion> ConfigVersions => Set<ConfigVersion>();
     public DbSet<MonitoringSession> MonitoringSessions => Set<MonitoringSession>();
 
-    public PulseDbContext(DbContextOptions<PulseDbContext> options) : base(options) { }
+    public PulseDbContext(DbContextOptions<PulseDbContext> options)
+        : base(options) { }
 
     protected override void OnModelCreating(ModelBuilder b)
     {

ThingConnect.Pulse.Server/Helpers/UnixTimestamp.cs

@@ -45,4 +45,4 @@ public static long Subtract(long unixSeconds, TimeSpan timeSpan)
     {
         return unixSeconds - (long)timeSpan.TotalSeconds;
     }
-}
+}