Merge branch 'master' of https://github.com/MachDatum/ThingConnect.Pulse into logo

Author: abishekve

.claude/settings.local.json

@@ -14,7 +14,8 @@
       "Bash(ping:*)",
       "Bash(findstr:*)",
       "Bash(npx eslint:*)",
-      "Read(//c/ProgramData/ThingConnect.Pulse/logs/**)"
+      "Read(//c/ProgramData/ThingConnect.Pulse/logs/**)",
+      "WebSearch"
     ],
     "deny": [],
     "ask": []

ThingConnect.Pulse.Server/Controllers/StatusController.cs

@@ -32,7 +32,7 @@ public async Task<ActionResult<LiveStatusItemDto>> GetLiveStatusAsync(
     {
         try
         {
-            _logger.LogInformation("Getting live status - group: {Group}, search: {Search}, page: {Page}, pageSize: {PageSize}",
+            _logger.LogInformation("Getting live status - group: {Group}, search: {Search}",
                 group, search);
 
             List<LiveStatusItemDto> result = await _statusService.GetLiveStatusAsync(group, search);

ThingConnect.Pulse.Server/Controllers/UserManagementController.cs

@@ -187,7 +187,7 @@ public async Task<ActionResult<UserInfoDto>> CreateUserAsync([FromBody] CreateUs
             _logger.LogInformation("User created: {Username} (ID: {UserId}) by admin {AdminId}",
                 user.UserName, user.Id, currentUser?.Id);
 
-            return CreatedAtAction(nameof(GetUserByIdAsync), new { id = user.Id }, new UserInfoDto
+            var userDto = new UserInfoDto
             {
                 Id = user.Id,
                 Username = user.UserName,
@@ -196,7 +196,11 @@ public async Task<ActionResult<UserInfoDto>> CreateUserAsync([FromBody] CreateUs
                 CreatedAt = user.CreatedAt,
                 LastLoginAt = user.LastLoginAt,
                 IsActive = user.IsActive
-            });
+            };
+
+            // Return Ok for now to avoid routing issues
+            // TODO: Fix location header generation
+            return Ok(userDto);
         }
         catch (Exception ex)
         {

ThingConnect.Pulse.Server/Services/Monitoring/OutageDetectionService.cs

@@ -530,6 +530,20 @@ private async Task SaveCheckResultAsync(CheckResult result, CancellationToken ca
         };
 
         context.CheckResultsRaw.Add(rawResult);
+
+        // Update LastRttMs for successful probes
+        if (result.Status == UpDown.up && result.RttMs.HasValue)
+        {
+            Data.Endpoint? endpoint = await context.Endpoints.FindAsync([result.EndpointId], cancellationToken);
+            if (endpoint != null)
+            {
+                endpoint.LastRttMs = result.RttMs.Value;
+                _logger.LogInformation(
+                    "Updated LastRttMs for endpoint {EndpointId} to {RttMs}ms",
+                    result.EndpointId, result.RttMs.Value);
+            }
+        }
+
         await context.SaveChangesAsync(cancellationToken);
     }
 }

ThingConnect.Pulse.Server/Services/StatusService.cs

@@ -87,6 +87,10 @@ public async Task<List<LiveStatusItemDto>> GetLiveStatusAsync(string? group, str
                 ? sparklineData[endpoint.Id]
                 : new List<SparklinePoint>();
 
+            _logger.LogInformation(
+                "Endpoint {EndpointName}: Status = {Status}, LastRttMs = {RttMs}, LastChangeTs = {LastChangeTs}",
+                endpoint.Name, status, endpoint.LastRttMs, endpoint.LastChangeTs);
+
             items.Add(new LiveStatusItemDto
             {
                 Endpoint = MapToEndpointDto(endpoint),

docs/rtt-tracing.md

@@ -0,0 +1,88 @@
+# RTT Value Tracing and Investigation
+
+## RTT Journey Flow Diagram
+
+```mermaid
+graph TD
+    A[Probe Service] -->|Measure RTT| B[CheckResult]
+    B -->|RttMs| C[MonitoringBackgroundService]
+    C -->|Update Endpoint| D[OutageDetectionService]
+    D -->|Persist LastRttMs| E[StatusService]
+    E -->|Serialize RTT| F[API Controller]
+    F -->|Response| G[Frontend Service]
+    G -->|Render| H[Frontend Components]
+
+    subgraph Potential Failure Points
+        A -->|Null/Zero RTT| B
+        B -->|Null RttMs| C
+        C -->|Ignore Null RTT| D
+        D -->|Skip Update| E
+        E -->|Empty RTT| F
+        F -->|Omit RTT| G
+        G -->|Display Placeholder| H
+    end
+```
+
+## RTT Tracing Points
+
+### 1. Probe Service (`ProbeService.cs`)
+- **Probe Types**:
+  - ICMP: Uses `reply.RoundtripTime`
+  - TCP: Uses `stopwatch.ElapsedMilliseconds`
+  - HTTP: Uses `stopwatch.ElapsedMilliseconds`
+- **Failure Handling**:
+  - Sets `RttMs` to null on probe failures
+  - Different measurement methods may introduce inconsistencies
+
+### 2. Background Monitoring Service
+- Logs RTT with trace:
+  ```csharp
+  _logger.LogTrace("Probed endpoint {EndpointId} ({Name}): {Status} in {RttMs}ms")
+  ```
+- Converts null RTT to "N/A"
+
+### 3. Outage Detection Service
+- Copies `result.RttMs` to new records
+- Potential loss point if RTT is null
+
+### 4. Status Service
+- Uses `endpoint.LastRttMs` to populate status responses
+- May return null/empty RTT
+
+### 5. Frontend Service and Components
+- Uses optional chaining and nullish coalescing
+- Handles null RTT with placeholders ('-')
+
+## Investigation Steps
+
+### 1. Probe Measurement Verification
+- [ ] Compare RTT measurements across different probe types
+- [ ] Add detailed logging in `ProbeService`
+- [ ] Verify stopwatch and `RoundtripTime` calculations
+
+### 2. Null Value Propagation Analysis
+- [ ] Trace null RTT through each service layer
+- [ ] Add comprehensive logging
+- [ ] Validate null handling in serialization
+
+### 3. API Contract Validation
+- [ ] Inspect API response DTOs
+- [ ] Check JSON serialization of RTT values
+- [ ] Verify optional/nullable field handling
+
+### 4. Frontend Parsing Investigation
+- [ ] Review TypeScript type definitions
+- [ ] Validate RTT parsing in API services
+- [ ] Test display logic for various RTT scenarios
+
+### 5. Comprehensive Test Scenarios
+- [ ] Successful probe with non-zero RTT
+- [ ] Failed probe (null RTT)
+- [ ] Edge cases: zero, very low, very high RTT values
+- [ ] Multiple probe type comparisons
+
+## Potential Improvement Recommendations
+- Standardize RTT measurement across probe types
+- Implement consistent null/zero RTT handling
+- Add more granular logging and tracing
+- Create comprehensive test suite for RTT propagation

thingconnect.pulse.client/obj/Debug/package.g.props

@@ -27,6 +27,7 @@
     <PackageJsonDependenciesNextThemes Condition="$(PackageJsonDependenciesNextThemes) == ''">^0.4.6</PackageJsonDependenciesNextThemes>
     <PackageJsonDependenciesReact Condition="$(PackageJsonDependenciesReact) == ''">^19.1.1</PackageJsonDependenciesReact>
     <PackageJsonDependenciesReactDom Condition="$(PackageJsonDependenciesReactDom) == ''">^19.1.1</PackageJsonDependenciesReactDom>
+    <PackageJsonDependenciesReactHookForm Condition="$(PackageJsonDependenciesReactHookForm) == ''">^7.62.0</PackageJsonDependenciesReactHookForm>
     <PackageJsonDependenciesReactIcons Condition="$(PackageJsonDependenciesReactIcons) == ''">^5.5.0</PackageJsonDependenciesReactIcons>
     <PackageJsonDependenciesReactRouterDom Condition="$(PackageJsonDependenciesReactRouterDom) == ''">^7.8.1</PackageJsonDependenciesReactRouterDom>
     <PackageJsonDependenciesZod Condition="$(PackageJsonDependenciesZod) == ''">^4.0.17</PackageJsonDependenciesZod>

thingconnect.pulse.client/package-lock.json

@@ -28,6 +28,7 @@
     "next-themes": "^0.4.6",
     "react": "^19.1.1",
     "react-dom": "^19.1.1",
+    "react-hook-form": "^7.62.0",
     "react-icons": "^5.5.0",
     "react-router-dom": "^7.8.1",
     "zod": "^4.0.17"

thingconnect.pulse.client/package.json

@@ -0,0 +1,95 @@
+import { apiClient } from '../client';
+import type {
+  UserInfo,
+  CreateUserRequest,
+  UpdateUserRequest,
+  ChangeRoleRequest,
+  ResetPasswordRequest,
+  UsersListParams,
+  PagedResult,
+} from '../types';
+
+export class UserManagementService {
+  /**
+   * Get paginated list of users with optional filtering
+   */
+  static async getUsers(params: UsersListParams = {}): Promise<PagedResult<UserInfo>> {
+    const searchParams = new URLSearchParams();
+
+    if (params.page) {
+      searchParams.append('page', params.page.toString());
+    }
+
+    if (params.pageSize) {
+      searchParams.append('pageSize', params.pageSize.toString());
+    }
+
+    if (params.search) {
+      searchParams.append('search', params.search);
+    }
+
+    if (params.role) {
+      searchParams.append('role', params.role);
+    }
+
+    if (params.isActive !== undefined) {
+      searchParams.append('isActive', params.isActive.toString());
+    }
+
+    const queryString = searchParams.toString();
+    const url = `/api/UserManagement${queryString ? `?${queryString}` : ''}`;
+
+    return apiClient.get<PagedResult<UserInfo>>(url);
+  }
+
+  /**
+   * Get a single user by ID
+   */
+  static async getUserById(id: string): Promise<UserInfo> {
+    return apiClient.get<UserInfo>(`/api/UserManagement/${encodeURIComponent(id)}`);
+  }
+
+  /**
+   * Create a new user (admin only)
+   */
+  static async createUser(request: CreateUserRequest): Promise<UserInfo> {
+    return apiClient.post<UserInfo>('/api/UserManagement', request);
+  }
+
+  /**
+   * Update user details
+   */
+  static async updateUser(id: string, request: UpdateUserRequest): Promise<UserInfo> {
+    return apiClient.put<UserInfo>(`/api/UserManagement/${encodeURIComponent(id)}`, request);
+  }
+
+  /**
+   * Delete a user
+   */
+  static async deleteUser(id: string): Promise<void> {
+    return apiClient.delete<void>(`/api/UserManagement/${encodeURIComponent(id)}`);
+  }
+
+  /**
+   * Change user role
+   */
+  static async changeUserRole(id: string, request: ChangeRoleRequest): Promise<UserInfo> {
+    return apiClient.put<UserInfo>(`/api/UserManagement/${encodeURIComponent(id)}/role`, request);
+  }
+
+  /**
+   * Reset user password (admin only)
+   */
+  static async resetUserPassword(id: string, request: ResetPasswordRequest): Promise<void> {
+    return apiClient.post<void>(`/api/UserManagement/${encodeURIComponent(id)}/reset-password`, request);
+  }
+
+  /**
+   * Toggle user active status
+   */
+  static async toggleUserStatus(id: string, isActive: boolean): Promise<UserInfo> {
+    return apiClient.put<UserInfo>(`/api/UserManagement/${encodeURIComponent(id)}`, {
+      isActive,
+    });
+  }
+}