Commit 682b2f4
docs: sweep remaining factual errors across all docs and protocol modules
Complete the corrections started in PR #27. That PR fixed README.md and
AGENTS_SETUP_INSTRUCTIONS.md but missed the same errors in protocol
READMEs, Python docstrings, the FAQ, and the protocols __init__.py.
Corrections applied across 8 files:
ACE naming: "Agentic Context Engine" → "Agentic Context Engineering"
- README.md, protocols/__init__.py, ace/README.md, ace/__init__.py,
docs/fava_trails_faq.md
ACE affiliations: "Stanford/SambaNova" → "Stanford, UC Berkeley, and SambaNova"
- README.md, AGENTS_SETUP_INSTRUCTIONS.md, ace/README.md, ace/__init__.py,
docs/fava_trails_faq.md
SECOM affiliations: "Microsoft" → "Tsinghua University and Microsoft"
- README.md, secom/README.md, secom/__init__.py, docs/fava_trails_faq.md
"Zero hallucination" → "Purely extractive" (papers don't make that claim)
- README.md, secom/README.md, docs/fava_trails_faq.md
OpenRouter "100+" → "300–500+" (missed occurrence in AGENTS_SETUP_INSTRUCTIONS.md)
Removed link to kayba-ai/agentic-context-engine (community reimplementation
that renames core ACE concepts; official repo is ace-agent/ace)
Fixed protocols/__init__.py docstring claiming protocols are not designed
to run simultaneously — they ARE composable (staggered order values:
ace=10, rlm=15, secom=20)
All 558 tests pass.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent 076ea1d commit 682b2f4
9 files changed
Lines changed: 21 additions & 20 deletions
File tree
- docs
- src/fava_trails/protocols
- ace
- secom
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
338 | 338 | | |
339 | 339 | | |
340 | 340 | | |
341 | | - | |
| 341 | + | |
342 | 342 | | |
343 | 343 | | |
344 | 344 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
226 | | - | |
| 226 | + | |
227 | 227 | | |
228 | 228 | | |
229 | 229 | | |
| |||
267 | 267 | | |
268 | 268 | | |
269 | 269 | | |
270 | | - | |
| 270 | + | |
271 | 271 | | |
272 | | - | |
| 272 | + | |
273 | 273 | | |
274 | 274 | | |
275 | 275 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
191 | | - | |
| 191 | + | |
192 | 192 | | |
193 | | - | |
| 193 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
| 111 | + | |
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments