Skip to content

Commit d38d4bb

Browse files
committed
ActivityTraceListenerManager test improvements.
1 parent 8da8764 commit d38d4bb

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

ClassLibraries/Macross.OpenTelemetry.Extensions/Test/ActivityTraceListenerManagerTests.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,16 @@ public void ActivitySampledWithRegistration()
7474

7575
activity.Stop();
7676

77+
Activity? activity2 = _ActivitySource.StartActivity("Test", ActivityKind.Server);
78+
/* Note: This could be a bug in OpenTelemetry. If root sampler
79+
is AlwaysOffSampler then StartActivity returns null. But if
80+
AlwaysOffSampler is used as an inner sampler, it creates
81+
propagation-only spans. */
82+
Assert.IsNotNull(activity2);
83+
Assert.IsFalse(activity2.IsAllDataRequested);
84+
Assert.IsFalse(activity2.Recorded);
85+
86+
Assert.AreEqual(1, registration.CompletedActivities.Count);
7787
Assert.IsTrue(registration.CompletedActivities.Contains(activity));
7888
}
7989

0 commit comments

Comments
 (0)