fix: max interval checks (diced#990)

* introduce max interval checks

* Update validate.ts

* Update validate.ts

* Update validate.ts

* Update validate.ts

Author: asimonson1125

src/lib/config/validate.ts

@@ -5,6 +5,11 @@ import { log } from '../logger';
 import { ParsedConfig } from './read';
 import { PROP_TO_ENV } from './read/env';
 import { checkOutput, COMPRESS_TYPES } from '../compress';
+import ms, { StringValue } from 'ms';
+
+// Maximum safe timeout value for JavaScript timers (32-bit signed integer limit)
+// Approximately 24.8 days
+const MAX_SAFE_TIMEOUT_MS = 2147483647;
 
 declare global {
   // eslint-disable-next-line @typescript-eslint/no-namespace
@@ -17,6 +22,23 @@ declare global {
   }
 }
 
+// Helper function to validate interval strings
+function validateInterval(value: string): boolean {
+  const intervalMs = ms(value as StringValue);
+  // ms() returns undefined for invalid strings, not throw
+  if (typeof intervalMs !== 'number') {
+    return false;
+  }
+  return intervalMs <= MAX_SAFE_TIMEOUT_MS;
+}
+
+// Reusable interval schema with validation
+const intervalSchema = (defaultValue: string) =>
+  z
+    .string()
+    .default(defaultValue)
+    .refine(validateInterval, 'Interval exceeds maximum safe timeout of ~24 days (2147483647ms)');
+
 export const discordContent = z
   .object({
     webhookUrl: z.url().nullable().default(null),
@@ -104,12 +126,12 @@ export const schema = z.object({
     enabled: z.boolean().default(true),
   }),
   tasks: z.object({
-    deleteInterval: z.string().default('30min'),
-    clearInvitesInterval: z.string().default('30min'),
-    maxViewsInterval: z.string().default('30min'),
-    thumbnailsInterval: z.string().default('30min'),
-    metricsInterval: z.string().default('30min'),
-    cleanThumbnailsInterval: z.string().default('1d'),
+    deleteInterval: intervalSchema('30min'),
+    clearInvitesInterval: intervalSchema('30min'),
+    maxViewsInterval: intervalSchema('30min'),
+    thumbnailsInterval: intervalSchema('30min'),
+    metricsInterval: intervalSchema('30min'),
+    cleanThumbnailsInterval: intervalSchema('1d'),
   }),
   files: z.object({
     route: z.string().startsWith('/').min(1).trim().toLowerCase().default('/u'),

src/lib/tasks/index.ts

@@ -82,6 +82,21 @@ export class Tasks {
       return;
     }
 
+    // Maximum safe timeout for JavaScript timers (32-bit signed integer limit)
+    // Approximately 24.8 days or 2,147,483,647 milliseconds
+    const MAX_SAFE_TIMEOUT_MS = 2147483647;
+
+    if (task.interval > MAX_SAFE_TIMEOUT_MS) {
+      this.logger.error('interval exceeds maximum safe timeout', {
+        id: task.id,
+        interval: task.interval,
+        maxSafeTimeout: MAX_SAFE_TIMEOUT_MS,
+        message: 'Interval exceeds JavaScript timer limit (~24 days). Task will not be started.',
+      });
+
+      return;
+    }
+
     task.started = true;
 
     const timeout = setInterval(task.func.bind(task), task.interval);