Skip to content

'done_info' not generated and incorrect reward counting on maximum steps completion #7

@xyzeroth

Description

@xyzeroth

It seems that when an actor successfully completes the maximum number of steps (2048) without failure,

any 'done_info' is not generated at Line 214,

and no 'done_info' is appended to 'completed_episode_info' at Line 296.

# If some of the actors finished AND this is not the last step

Consequently, the reward is counted as -1, as observed in the code snippet at Line 324.

If an actor reaches the maximum step without any failures, it should be considered 'done,' and the reward should be counted to the total reward as it is, rather than being set to -1.
Could you please examine how the reward is tallied when an actor successfully completes the maximum number of steps without any failures?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions