You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: scripts/check_modules.py
+17-1Lines changed: 17 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -365,7 +365,7 @@ def check_modules():
365
365
f"Recommendation: Found `{search_string}` in file `{file_path.name}`: Config would be cleaner using 'stylelint-prettier/recommended'. [See here](https://github.com/prettier/stylelint-prettier)."
"Recommendation: The README seems to have a config example without a trailing comma. Please add one ([basic instructions](https://github.com/MagicMirrorOrg/MagicMirror-3rd-Party-Modules/blob/main/guides/readme_bestpractices.md#Config-Instructions))."
414
414
)
415
+
416
+
# Search for clone instructions in README
417
+
found_clone_instructions=search_in_file(
418
+
file_path, "git clone")
419
+
ifnotfound_clone_instructions:
420
+
module["issues"].append(
421
+
"Recommendation: The README seems not to have clone instructions."
422
+
)
423
+
else:
424
+
# Check if repo URL is correct
425
+
found_repo_url=search_in_file(
426
+
file_path, f"git clone {module['url']}")
427
+
ifnotfound_repo_url:
428
+
module["issues"].append(
429
+
"Recommendation: The README seems to have incorrect clone instructions. Please check the URL."
0 commit comments