chore: retire legacy python tooling

Author: KristjanESPERANTO

.gitignore

@@ -3,7 +3,6 @@
 /modules_/*
 /modules_temp/*
 /node_modules/*
-/scripts/__pycache__/*
 .eslintcache
 .idea
 .vscode/*

.pylintrc

@@ -1,4 +1,8 @@
-FROM nikolaik/python-nodejs:latest AS builder
+FROM node:slim AS builder
+
+RUN apt-get update \
+	&& apt-get install -y --no-install-recommends git \
+	&& rm -rf /var/lib/apt/lists/*
 
 WORKDIR /workspace
 
@@ -10,7 +14,6 @@ set -e
 git config --global --add safe.directory /workspace
 git log -1
 export GITHUB_TOKEN="${GITHUB_TOKEN}"
-pip install requests
 npm clean-install
 node --run all
 EOF

container/Dockerfile

@@ -11,7 +11,7 @@
     "bergfex",
     "bugsounet",
     "checkjs",
-    "checkpy",
+    "checkts",
     "codeberg",
     "Cutover",
     "diffing",
@@ -36,7 +36,6 @@
     "omxplayer",
     "openweathermap",
     "ptrbld",
-    "PYTHONPATH",
     "ratp",
     "refspecs",
     "rollup",

cspell.config.json

@@ -6,11 +6,8 @@ Welcome! This document bundles the day-to-day tasks contributors perform when wo
 
 ```bash
 npm install
-python3 -m venv .venv && source .venv/bin/activate  # optional but recommended for Python scripts
 ```
 
-The Node and Python scripts live side by side today. The roadmap tracks our plan to consolidate runtimes, but for now please ensure both toolchains are available.
-
 ## Running the pipeline
 
 You can run each stage individually or rely on the helper commands registered in `package.json`:
@@ -22,7 +19,7 @@ You can run each stage individually or rely on the helper commands registered in
 | `node --run getModules`           | Stage 3 – clone the repos locally for deeper inspection.                        |
 | `node --run expandModuleList`     | Stage 4 – parse `package.json`, pick screenshots, and compute derived metadata. |
 | `node --run checkModulesJs`       | Stage 5a – JavaScript checks against the cloned repositories.                   |
-| `node --run checkModules`         | Stage 5b – Python checks to surface README and packaging issues.                |
+| `node --run checkModules`         | Stage 5b – Deep TypeScript checks to surface README and packaging issues.       |
 | `node --run all`                  | Convenience wrapper that executes the full chain in order.                      |
 
 Heavy stages (`getModules`, `checkModules`) download hundreds of repositories and can take more than 10 minutes. When iterating on faster tasks (Stage 1–2, Stage 4), feel free to skip the expensive steps.
@@ -55,9 +52,7 @@ Runs JavaScript-based checks (naming conventions, minified files, etc.) against
 
 #### Stage 5b – `check-modules/index.ts`
 
-Runs the deep repository analysis in TypeScript, mirroring the legacy Python behavior while sharing utilities with the rest of the pipeline. It parses README files, inspects packaging hygiene, shells out to ESLint/`npm-check-updates`, and produces the markdown summary alongside `modules.json`, `modules.min.json`, and `stats.json`.
-
-> Legacy fallback: the historical Python implementation (`scripts/check_modules.py`) remains available for parity comparisons. Invoke it via `pipeline run --only=check-modules --checks=legacy` when you need to diff outputs against the TypeScript stage.
+Runs the deep repository analysis in TypeScript, parsing README files, inspecting packaging hygiene, shelling out to ESLint/`npm-check-updates`, and producing the markdown summary alongside `modules.json`, `modules.min.json`, and `stats.json`.
 
 #### `validate_release_artifacts.js`
 
@@ -117,7 +112,7 @@ The bundled files live in `dist/schemas/`. They ship with the repository so `nod
 
 ## Prerequisites & installation
 
-1. Install [Node.js](https://nodejs.org). Python is optional unless you plan to run the legacy comparison harness.
+1. Install [Node.js](https://nodejs.org).
 2. Clone the repository:
    ```bash
    git clone https://github.com/MagicMirrorOrg/MagicMirror-3rd-Party-Modules

docs/CONTRIBUTING.md

@@ -2,9 +2,9 @@
 
 Visibility into the automation that builds and publishes the third-party module catalogue helps contributors reason about changes and spot failure points early. This document summarizes the current pipeline, highlights the target architecture we are steering toward, and links each element back to the modernization roadmap.
 
-## Current state (September 2025)
+## Current state (October 2025)
 
-The production pipeline is orchestrated via `node scripts/orchestrator/index.js run full-refresh` (or the shorthand npm scripts) and progresses through six sequential stages. Most stages are implemented in TypeScript/Node.js and reuse the shared utility layer introduced in P2.1; the final deep-analysis stage remains Python for now. Each stage produces a well-defined artifact that ships with a JSON Schema contract enforced at the boundary.
+The production pipeline is orchestrated via `node scripts/orchestrator/index.js run full-refresh` (or the shorthand npm scripts) and progresses through six sequential stages. All stages are now implemented in TypeScript/Node.js and reuse the shared utility layer introduced in P2.1. Each stage produces a well-defined artifact that ships with a JSON Schema contract enforced at the boundary.
 
 ### Stage overview
 
@@ -15,19 +15,19 @@ The production pipeline is orchestrated via `node scripts/orchestrator/index.js
 | 3     | `get-modules`            | TypeScript | `website/data/modules.stage.3.json`, `modules/`, `modules_temp/`                                             |
 | 4     | `expand-module-list`     | Node.js    | `website/data/modules.stage.4.json`, `website/images/`                                                       |
 | 5     | `check-modules-js`       | Node.js    | `website/data/modules.stage.5.json`                                                                          |
-| 6     | `check-modules`          | Python     | `website/data/modules.json`, `website/data/modules.min.json`, `website/data/stats.json`, `website/result.md` |
+| 6     | `check-modules`          | TypeScript | `website/data/modules.json`, `website/data/modules.min.json`, `website/data/stats.json`, `website/result.md` |
 
 ### Current workflow diagram
 
 ```mermaid
 flowchart LR
   orchestrator[["Node orchestrator CLI (stage-graph.json)"]]
-  orchestrator --> create{{"Create module list - TypeScript"}}
-  orchestrator --> update{{"Update repository metadata - TypeScript"}}
+  orchestrator --> create{{"Create module list - Node.js"}}
+  orchestrator --> update{{"Update repository metadata - Node.js"}}
   orchestrator --> fetch{{"Fetch module repos - TypeScript"}}
-  orchestrator --> enrich{{"Enrich with package metadata - TypeScript"}}
+  orchestrator --> enrich{{"Enrich with package metadata - Node.js"}}
   orchestrator --> checkjs{{"Static checks - Node.js"}}
-  orchestrator --> checkpy{{"Deep analysis - Python"}}
+  orchestrator --> checkts{{"Deep analysis - TypeScript"}}
 
   create --> stage1["modules.stage.1.json"]
   stage1 --> update
@@ -37,14 +37,14 @@ flowchart LR
   fetch --> clones[("modules/, modules_temp/")]
   enrich -- "modules.stage.4.json" --> checkjs
   enrich --> images[("website/images/")]
-  checkjs -- "modules.stage.5.json" --> checkpy
-  checkpy --> outputs[("modules.json, modules.min.json, stats.json, result.md")]
+  checkjs -- "modules.stage.5.json" --> checkts
+  checkts --> outputs[("modules.json, modules.min.json, stats.json, result.md")]
 ```
 
 ### Observations
 
 - Stage contracts are codified via the bundled schemas stored under `dist/schemas/` (sources live in `pipeline/schemas/src/`).
-- Cross-cutting utilities (HTTP, Git, filesystem, rate limiting) now live in `scripts/shared/` and are reused by the TypeScript stages.
+- Cross-cutting utilities (HTTP, Git, filesystem, rate limiting) now live in `scripts/shared/` and are reused by every TypeScript stage, including the deep-analysis step.
 - The orchestrator CLI runs the declarative stage graph and supports `--only/--skip`, retries, and shared logging.
 
 ### Legacy workflow snapshot (pre-September 2025)
@@ -60,8 +60,8 @@ flowchart LR
   getLegacy --> clonesLegacy[("modules/, modules_temp/")]
   expandLegacy -- "modules.stage.4.json" --> checkjsLegacy{{"Static checks - Node.js"}}
   expandLegacy --> imagesLegacy[("website/images/")]
-  checkjsLegacy -- "modules.stage.5.json" --> checkpyLegacy{{"Deep analysis - Python"}}
-  checkpyLegacy --> outputsLegacy[("modules.json, modules.min.json, stats.json, result.md")]
+  checkjsLegacy -- "modules.stage.5.json" --> checkLegacy{{"Deep analysis - Python"}}
+  checkLegacy --> outputsLegacy[("modules.json, modules.min.json, stats.json, result.md")]
 ```
 
 This legacy diagram captures the pre-orchestrator, mixed-runtime pipeline that relied on direct node and Python scripts. Retaining it here provides a historical comparison as we continue to modernize the remaining stages.

docs/architecture.md

@@ -24,13 +24,13 @@ This document captures the long-term improvements we want to implement in the mo
 
 ### 2. Runtime & Codebase Consolidation
 
-| Task | Description                                                                                                                                                                          | Dependencies | Effort |
-| ---- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | ------------ | ------ |
-| P2.1 | Extract shared utilities (HTTP, Git, FS, logging, rate-limiter) into a reusable Node/TS module ✅ Completed Sep 2025                                                                 | none         | M      |
-| P2.2 | Port `get_modules.py` to TypeScript, reusing the shared utilities ✅ Completed Sep 2025 (Python fallback removed)                                                                    | P2.1         | L      |
-| P2.3 | Port `check_modules.py` logic incrementally (start with fast checks, then optional heavy tasks) ✅ Completed Oct 2025 (TS stage default, Python fallback kept via `--checks=legacy`) | P2.1         | XL     |
-| P2.4 | Enable TypeScript build tooling (tsconfig, lint) and cover new modules with tests                                                                                                    | P2.1         | M      |
-| P2.5 | Centralize `package.json` ingestion so data is parsed once and shared across stages                                                                                                  | P2.1         | M      |
+| Task | Description                                                                                                                                                                    | Dependencies | Effort |
+| ---- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | ------------ | ------ |
+| P2.1 | Extract shared utilities (HTTP, Git, FS, logging, rate-limiter) into a reusable Node/TS module ✅ Completed Sep 2025                                                           | none         | M      |
+| P2.2 | Port `get_modules.py` to TypeScript, reusing the shared utilities ✅ Completed Sep 2025 (Python fallback removed)                                                              | P2.1         | L      |
+| P2.3 | Port `check_modules.py` logic incrementally (start with fast checks, then optional heavy tasks) ✅ Completed Oct 2025 (TS stage now fully TypeScript; Python fallback removed) | P2.1         | XL     |
+| P2.4 | Enable TypeScript build tooling (tsconfig, lint) and cover new modules with tests                                                                                              | P2.1         | M      |
+| P2.5 | Centralize `package.json` ingestion so data is parsed once and shared across stages                                                                                            | P2.1         | M      |
 
 ### 3. Robustness & Performance Safety Nets
 
@@ -98,6 +98,7 @@ Immediate action items:
 1. Kick off P2.4: land TypeScript build/lint tooling across the new stages and wire them into CI.
 2. Expand the comparison harness diff coverage (README/HTML, stats thresholds) per the fixture plan follow-ups.
 3. Prioritize P4.x registry metadata work now that parity is secured (define categories/severities for existing checks).
+4. Decide on the long-term diff strategy (e.g. golden artifacts) now that the Python fallback is gone.
 
 ---
 

docs/pipeline-refactor-roadmap.md

@@ -6,9 +6,9 @@ This page consolidates the material that previously lived in the P2.3 rollout do
 
 ## Status snapshot
 
-- ✅ TypeScript implementation is the default Stage 5 runner; the Python fallback remains available behind `--checks=legacy` for comparison runs only.
-- ✅ Comparison harness (`npm run checkModules:compare`) executes both implementations, produces diff artifacts, and runs in CI via `check-modules-compare.yaml`.
-- 🔄 Follow-ups tracked here: extend harness diff coverage (README/HTML artifacts) and define warning/failure thresholds before we retire the legacy stage entirely.
+- ✅ TypeScript implementation is the default Stage 5 runner.
+- ✅ Comparison harness (`npm run checkModules:compare`) can execute multiple commands, capture artifacts, and (when two runs complete) produce diffs for analysis.
+- 🔄 Follow-ups tracked here: extend harness diff coverage (README/HTML artifacts) and define warning/failure thresholds ahead of diff gating in CI.
 
 ## Rule inventory
 
@@ -79,8 +79,8 @@ These are the rule IDs currently implemented by the TypeScript checker. Keep thi
 - `detect-jquery-local-copy`: warns when a local `jquery.js` copy is bundled.
 - `detect-missing-update-section`: ensures README files include `## Update`.
 - `detect-missing-install-section`: ensures README files include `## Install`.
-- `deprecation_check`: runs `npm-deprecated-check` and aggregates results.
-- `eslint_checks`: executes ESLint with the curated configuration to produce findings.
+- `dependency-deprecation-helper`: runs `npm-deprecated-check` and aggregates results.
+- `eslint-helper`: executes ESLint with the curated configuration to produce findings.
 
 ## Fixture coverage
 
@@ -103,8 +103,8 @@ The curated fixture repositories live in `fixtures/modules/`. Keep this table in
 | `synthetic-lockfile`                | Synthetic       | Legacy lockfile versions                  | `lock-deprecated-v1`, `lock-deprecated-v2`                                                                                                                                                                                                                             | Ready  | Located under `fixtures/modules/synthetic-lockfile`.                               |
 | `synthetic-readme-heuristics`       | Synthetic       | README structure + node_modules detection | `detect-missing-install-section`, `detect-missing-update-section`, `detect-node_modules-dir`                                                                                                                                                                           | Ready  | Located under `fixtures/modules/synthetic-readme-heuristics`.                      |
 | `synthetic-jquery-local`            | Synthetic       | Local jQuery copy                         | `detect-jquery-local-copy`                                                                                                                                                                                                                                             | Ready  | Located under `fixtures/modules/synthetic-jquery-local`.                           |
-| `synthetic-eslint-helper`           | Synthetic       | ESLint integration                        | `eslint_checks`                                                                                                                                                                                                                                                        | Ready  | Located under `fixtures/modules/synthetic-eslint-helper`.                          |
-| `synthetic-deprecation-helper`      | Synthetic       | npm deprecated packages via helper        | `deprecation_check`                                                                                                                                                                                                                                                    | Ready  | Located under `fixtures/modules/synthetic-deprecation-helper`.                     |
+| `synthetic-eslint-helper`           | Synthetic       | ESLint integration                        | `eslint-helper`                                                                                                                                                                                                                                                        | Ready  | Located under `fixtures/modules/synthetic-eslint-helper`.                          |
+| `synthetic-deprecation-helper`      | Synthetic       | npm deprecated packages via helper        | `dependency-deprecation-helper`                                                                                                                                                                                                                                        | Ready  | Located under `fixtures/modules/synthetic-deprecation-helper`.                     |
 
 ### Coverage matrix
 
@@ -131,23 +131,23 @@ The comparison harness lives under `scripts/check-modules/compare/` and is exerc
 
 ### Goals
 
-- Execute legacy (`--checks=legacy`) and TypeScript implementations against the same curated dataset.
-- Normalize and diff Stage 5 outputs, surfacing rule-level differences and aggregate stats.
+- Execute one or two configured commands against the curated dataset.
+- Normalize and diff Stage 5 outputs, surfacing rule-level differences and aggregate stats when two runs are available.
 - Emit machine-readable (`diff.json`) and Markdown (`diff.md`) reports for CI artifacts.
 
 ### Flow
 
 1. Prepare a temporary workspace with the curated fixtures.
-2. Run the legacy stage via the orchestrator, capturing Stage 5 outputs.
-3. Run the TypeScript stage (default) in a separate directory.
+2. Run the first configured command (labelled `legacy` by default) and capture Stage 5 outputs.
+3. Run the second command (`ts` by default) if provided.
 4. Normalize artifacts (sorted keys, trimmed timestamps).
-5. Run diff logic to produce JSON + Markdown summaries.
+5. Run diff logic to produce JSON + Markdown summaries when two runs succeed.
 6. Exit non-zero when differences are detected or an execution step fails.
 
 ### Implementation notes
 
 - CLI entry point: `node scripts/check-modules/compare/index.js`.
-- Supports overrides via `--fixtures`, `--legacy`, `--ts`, and `--output` flags.
+- Supports overrides via `--fixtures`, `--legacy`, `--ts`, and `--output` flags (the `--legacy` command defaults to `skip`).
 - Uses shared logging utilities; artifacts are collated under the run directory with a `plan.json` descriptor.
 - Snapshot-based tests guard the harness itself.
 
@@ -156,6 +156,7 @@ The comparison harness lives under `scripts/check-modules/compare/` and is exerc
 - Add README/HTML artifact comparisons to the diff output.
 - Define thresholds that downgrade certain differences to warnings instead of hard failures.
 - Consider partial rule subsets to speed up ad-hoc debugging runs.
+- Explore storing golden artifacts now that the Python fallback has been retired.
 
 ## Housekeeping