Commit 0523f63
committed
[test] replace
`node-libgpiod` uses deprecated NAN which is incompatible with Electron v39+.
`serialport` uses N-API ensuring compatibility with current and future Electron versions.
`node-libgpiod` is only used by 1 of ~1300 3rd-party-modules (MMM-PresenceScreenControl),
while serialport is used by at least 4 modules (MMM-Serial-Notification,
MMM-RadarPresence, MMM-LKY-TIC and MMM-Gestures), making it a better test candidate.
Also updates Electron to v39.
Fixes #3933node-libgpiod with serialport in electron-rebuild workflow1 parent d7348ed commit 0523f63
File tree
4 files changed
+8
-11
lines changed- .github/workflows
4 files changed
+8
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
| 24 | + | |
| 25 | + | |
30 | 26 | | |
31 | 27 | | |
32 | 28 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | | - | |
| 124 | + | |
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| |||
0 commit comments