Skip to content

Commit 0523f63

Browse files
[test] replace node-libgpiod with serialport in electron-rebuild workflow
`node-libgpiod` uses deprecated NAN which is incompatible with Electron v39+. `serialport` uses N-API ensuring compatibility with current and future Electron versions. `node-libgpiod` is only used by 1 of ~1300 3rd-party-modules (MMM-PresenceScreenControl), while serialport is used by at least 4 modules (MMM-Serial-Notification, MMM-RadarPresence, MMM-LKY-TIC and MMM-Gestures), making it a better test candidate. Also updates Electron to v39. Fixes #3933
1 parent d7348ed commit 0523f63

File tree

4 files changed

+8
-11
lines changed

4 files changed

+8
-11
lines changed

.github/workflows/electron-rebuild.yaml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,8 @@ jobs:
2121
run: node --run install-mm
2222
- name: Install @electron/rebuild
2323
run: npm install @electron/rebuild
24-
- name: Install node-libgpiod deps
25-
run: |
26-
sudo apt-get update
27-
sudo apt-get install gpiod libgpiod2 libgpiod-dev
28-
- name: Install test library (node-libgpiod) to be rebuilded
29-
run: npm install node-libgpiod
24+
- name: Install test library (serialport) to be rebuilt
25+
run: npm install serialport
3026
- name: Run electron-rebuild
3127
run: npx electron-rebuild
3228
continue-on-error: false

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ planned for 2026-01-01
2323
- [calendar] test: remove "Recurring event per timezone" test (#3929)
2424
- [calendar] chore: remove `requiresVersion: "2.1.0"` (#3932)
2525
- [tests] migrate from `jest` to `vitest` (#3940, #3941)
26+
- [tests] replace `node-libgpiod` with `serialport` in electron-rebuild workflow (#3945)
2627

2728
### Fixed
2829

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
"vitest": "^4.0.6"
122122
},
123123
"optionalDependencies": {
124-
"electron": "^38.3.0"
124+
"electron": "^39.0.0"
125125
},
126126
"engines": {
127127
"node": ">=22.20.0 <23 || >=24"

0 commit comments

Comments
 (0)