Typos and whiteline cleanups

Author: veeck

modules/default/weather/providers/envcanada.js

@@ -66,17 +66,13 @@ WeatherProvider.register("envcanada", {
 
 	/*
 	 * Override the fetchCurrentWeather method to query EC and construct a Current weather object
-	 *
 	 */
 	fetchCurrentWeather () {
-
 		this.fetchCommon("Current");
-
 	},
 
 	/*
 	 * Override the fetchWeatherForecast method to query EC and construct Forecast/Daily weather objects
-	 *
 	 */
 	fetchWeatherForecast () {
 
@@ -86,12 +82,9 @@ WeatherProvider.register("envcanada", {
 
 	/*
 	 * Override the fetchWeatherHourly method to query EC and construct Hourly weather objects
-	 *
 	 */
 	fetchWeatherHourly () {
-
 		this.fetchCommon("Hourly");
-
 	},
 
 	/*
@@ -108,7 +101,6 @@ WeatherProvider.register("envcanada", {
 	 *    city specified in the Weather module Config information
 	 */
 	fetchCommon (target) {
-
 		const forecastURL = this.getUrl(); // Get the approriate URL for the MSC Datamart Index page
 
 		Log.debug(`[weather.envcanada] ${target} Index url: ${forecastURL}`);
@@ -122,13 +114,13 @@ WeatherProvider.register("envcanada", {
 					return;
 				}
 
-				/*
-			 * With the Index page read, we must locate the filename/link for the specified city (aka Sitecode).
-			 * This is done by building the city filename and searching for it on the Index page. Once found,
- 			 * extract the full filename (a unique name that includes dat/time, filename, etc.) and then add it
-			 * to the Index page URL to create the proper URL pointing to the city's weather data. Finally, read the
-			 * URL to pull in the city's XML document so that weather data can be parsed and displayed.
-			 */
+				/**
+				 * With the Index page read, we must locate the filename/link for the specified city (aka Sitecode).
+				 * This is done by building the city filename and searching for it on the Index page. Once found,
+				 * extract the full filename (a unique name that includes dat/time, filename, etc.) and then add it
+				 * to the Index page URL to create the proper URL pointing to the city's weather data. Finally, read the
+				 * URL to pull in the city's XML document so that weather data can be parsed and displayed.
+				 */
 
 				let forecastFile = "";
 				let forecastFileURL = "";
@@ -160,14 +152,12 @@ WeatherProvider.register("envcanada", {
 					return;
 				}
 
-
 				if (target === "Hourly" && this.lastCityPageHourly === forecastFileURL) {
 					Log.debug(`[weather.envcanada] ${target} - Newest Citypage has already been seen - skipping!`);
 					this.updateAvailable(); // Update anyways to reset refresh timer
 					return;
 				}
 
-
 				this.fetchData(forecastFileURL, "xml") // Read city's URL to get weather data
 					.then((cityData) => {
 						if (!cityData) {
@@ -183,32 +173,22 @@ WeatherProvider.register("envcanada", {
 						Log.debug(`[weather.envcanada] ${target} - Citypage has been read and will be processed for updates`);
 
 						if (target === "Current") {
-
 							const currentWeather = this.generateWeatherObjectFromCurrentWeather(cityData);
-
 							this.setCurrentWeather(currentWeather);
-
 							this.lastCityPageCurrent = forecastFileURL;
 						}
 
 						if (target === "Forecast") {
-
 							const forecastWeather = this.generateWeatherObjectsFromForecast(cityData);
-
 							this.setWeatherForecast(forecastWeather);
-
 							this.lastCityPageForecast = forecastFileURL;
 						}
 
 						if (target === "Hourly") {
-
 							const hourlyWeather = this.generateWeatherObjectsFromHourly(cityData);
-
 							this.setWeatherHourly(hourlyWeather);
-
 							this.lastCityPageHourly = forecastFileURL;
 						}
-
 					})
 					.catch(function (cityRequest) {
 						Log.info(`weather.envcanada ${target} - could not load citypage data from: ${forecastFileURL}`);
@@ -219,8 +199,6 @@ WeatherProvider.register("envcanada", {
 				Log.error(`weather.envcanada ${target} - could not load index data ... `, indexRequest);
 				this.updateAvailable(); // If there were issues, update anyways to reset timer
 			});
-
-
 	},
 
 	/*
@@ -230,11 +208,9 @@ WeatherProvider.register("envcanada", {
 	 *   Fixed value + Prov code specified in Weather module Config.js + current hour as GMT
 	 */
 	getUrl () {
-
 		let forecastURL = `https://dd.weather.gc.ca/citypage_weather/${this.config.provCode}`;
 		const hour = this.getCurrentHourGMT();
 		forecastURL += `/${hour}/`;
-
 		return forecastURL;
 	},
 
@@ -269,7 +245,6 @@ WeatherProvider.register("envcanada", {
 		}
 
 		currentWeather.windSpeed = WeatherUtils.convertWindToMs(ECdoc.querySelector("siteData currentConditions wind speed").textContent);
-
 		currentWeather.windFromDirection = ECdoc.querySelector("siteData currentConditions wind bearing").textContent;
 
 		currentWeather.humidity = ECdoc.querySelector("siteData currentConditions relativeHumidity").textContent;
@@ -332,7 +307,7 @@ WeatherProvider.register("envcanada", {
 		/*
 		 * The EC forecast is held in a 12-element array - Elements 0 to 11 - with each day encompassing
 		 * 2 elements. the first element for a day details the Today (daytime) forecast while the second
-		 * element details the Tonight (nightime) forecast. Element 0 is always for the current day.
+		 * element details the Tonight (nighttime) forecast. Element 0 is always for the current day.
 		 *
 		 * However... the forecast is somewhat 'rolling'.
 		 *
@@ -343,7 +318,7 @@ WeatherProvider.register("envcanada", {
 		 *
 		 * But, if the EC forecast is queried in late afternoon, the Current Today forecast will be rolled
 		 * off and Element 0 will contain Current Tonight. From there, the next 5 days will be contained in
-		 * Elements 1/2, 3/4, 5/6, 7/8, and 9/10. As well, Elelement 11 will contain a forecast for a 6th day,
+		 * Elements 1/2, 3/4, 5/6, 7/8, and 9/10. As well, Element 11 will contain a forecast for a 6th day,
 		 * but only for the Today portion (not Tonight). This module will create a 6-day forecast using
 		 * Elements 0 to 11, and will ignore the additional Todat forecast in Element 11.
 		 *
@@ -554,17 +529,17 @@ WeatherProvider.register("envcanada", {
 	 * then it will be displayed ONLY if no POP is present.
 	 *
 	 * POP Logic: By default, we want to show the POP for 'daytime' since we are presuming that is what
-	 * people are more interested in seeing. While EC provides a separate POP for daytime and nightime portions
+	 * people are more interested in seeing. While EC provides a separate POP for daytime and nighttime portions
 	 * of each day, the weather module does not really allow for that view of a daily forecast. There we will
-	 * ignore any nightime portion. There is an exception however! For the Current day, the EC data will only show
-	 * the nightime forecast after a certain point in the afternoon. As such, we will be showing the nightime POP
+	 * ignore any nighttime portion. There is an exception however! For the Current day, the EC data will only show
+	 * the nighttime forecast after a certain point in the afternoon. As such, we will be showing the nighttime POP
 	 * (if one exists) in that specific scenario.
 	 *
 	 * Accumulation Logic: Similar to POP, we want to show accumulation for 'daytime' since we presume that is what
-	 * people are interested in seeing. While EC provides a separate accumulation for daytime and nightime portions
+	 * people are interested in seeing. While EC provides a separate accumulation for daytime and nighttime portions
 	 * of each day, the weather module does not really allow for that view of a daily forecast. There we will
-	 * ignore any nightime portion. There is an exception however! For the Current day, the EC data will only show
-	 * the nightime forecast after a certain point in that specific scenario.
+	 * ignore any nighttime portion. There is an exception however! For the Current day, the EC data will only show
+	 * the nighttime forecast after a certain point in that specific scenario.
 	 */
 	setPrecipitation (weather, foreGroup, today) {
 		if (foreGroup[today].querySelector("precipitation accumulation")) {