Skip to content

Commit 24d9b70

Browse files
authored
fix access denied fault error writing js/positions.js (#3652)
if the MagicMirror js folder is not writable (synology nas created by different user than docker container) there is an uncaught throw ``` [ERROR] EACCES: permission denied, open 'js/positions.js' ``` add try/catch, output new message, console.error ```text unable to write js/positions.js with the discovered module positions make the MagicMirror/js folder writeable by the user starting MagicMirror ``` MM will start, but no modules will show, as no positions were discovered this file is used to pass the list from the server side to the browser side fixes #3651
1 parent 786eacf commit 24d9b70

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ _This release is scheduled to be released on 2025-01-01._
3030
- [core] Run code style checks in workflow only once (#3648)
3131
- [core] Fix animations export #3644 only on server side (#3649)
3232
- [core] Use project URL in fallback config.
33+
- [core] fix Access Denied crash writing js/positions.js (on synology nas) #3651. new message, MM starts, but no modules showing
3334

3435
### Removed
3536

js/utils.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,12 @@ module.exports = {
6565
modulePositions.push(positionName);
6666
}
6767
});
68-
fs.writeFileSync(discoveredPositionsJSFilename, `const modulePositions=${JSON.stringify(modulePositions)}`);
68+
try {
69+
fs.writeFileSync(discoveredPositionsJSFilename, `const modulePositions=${JSON.stringify(modulePositions)}`);
70+
}
71+
catch (error) {
72+
console.error("unable to write js/positions.js with the discovered module positions\nmake the MagicMirror/js folder writeable by the user starting MagicMirror");
73+
}
6974
}
7075
// return the list to the caller
7176
return modulePositions;

0 commit comments

Comments
 (0)