Skip to content

Commit 30e1d09

Browse files
committed
fix access denied crash writing js/positions.js #3651
1 parent 5232f46 commit 30e1d09

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ _This release is scheduled to be released on 2025-01-01._
2828

2929
- [core] Run code style checks in workflow only once.
3030
- [core] fix animations export #3644 only on server side
31+
- [core] fix Access Denied crash writing js/positions.js (on synology nas) #3651. new message, MM starts, but no modules showing, positions list empty
3132

3233
### Removed
3334

js/utils.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,12 @@ module.exports = {
6565
modulePositions.push(positionName);
6666
}
6767
});
68-
fs.writeFileSync(discoveredPositionsJSFilename, `const modulePositions=${JSON.stringify(modulePositions)}`);
68+
try {
69+
fs.writeFileSync(discoveredPositionsJSFilename, `const modulePositions=${JSON.stringify(modulePositions)}`);
70+
}
71+
catch (error) {
72+
console.error("unable to write js/positions.js with the discovered module positions\nmake the MagicMirror/js folder writeable by the user starting MagicMirror");
73+
}
6974
}
7075
// return the list to the caller
7176
return modulePositions;

0 commit comments

Comments
 (0)