Skip to content

Commit 3cf58fe

Browse files
committed
review logger factory code part: use switch/case
1 parent ee87483 commit 3cf58fe

File tree

2 files changed

+24
-14
lines changed

2 files changed

+24
-14
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ planned for 2025-07-01
5151
### Updated
5252

5353
- [core] Update dependencies including electron to v36 (#3774, #3788, #3811)
54+
- [logger] Review factory code part: use `switch/case` instead of `if/else if` (#XXXX)
5455

5556
## [2.31.0] - 2025-04-01
5657

js/logger.js

Lines changed: 23 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,26 +11,35 @@
1111
label: (arg) => {
1212
const { method, defaultTokens } = arg;
1313
let label = defaultTokens.label(arg);
14-
if (method === "error") {
15-
label = styleText("red", label);
16-
} else if (method === "warn") {
17-
label = styleText("yellow", label);
18-
} else if (method === "debug") {
19-
label = styleText("bgBlue", label);
20-
} else if (method === "info") {
21-
label = styleText("blue", label);
14+
switch (method) {
15+
case "error":
16+
label = styleText("red", label);
17+
break;
18+
case "warn":
19+
label = styleText("yellow", label);
20+
break;
21+
case "debug":
22+
label = styleText("bgBlue", label);
23+
break;
24+
case "info":
25+
label = styleText("blue", label);
26+
break;
2227
}
2328
return label;
2429
},
2530
msg: (arg) => {
2631
const { method, defaultTokens } = arg;
2732
let msg = defaultTokens.msg(arg);
28-
if (method === "error") {
29-
msg = styleText("red", msg);
30-
} else if (method === "warn") {
31-
msg = styleText("yellow", msg);
32-
} else if (method === "info") {
33-
msg = styleText("blue", msg);
33+
switch (method) {
34+
case "error":
35+
msg = styleText("red", msg);
36+
break;
37+
case "warn":
38+
msg = styleText("yellow", msg);
39+
break;
40+
case "info":
41+
msg = styleText("blue", msg);
42+
break;
3443
}
3544
return msg;
3645
}

0 commit comments

Comments
 (0)