Skip to content

Commit 76fac78

Browse files
Run code style checks in workflow only once (#3648)
It's enough if the code style checks are successful once, it's not necessary to run them with every node version. Also, if there is an error, we can see more quickly whether it is a code style or a test-runner issue.
1 parent 5b7b76c commit 76fac78

File tree

2 files changed

+28
-8
lines changed

2 files changed

+28
-8
lines changed

.github/workflows/automated-tests.yaml

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,26 @@ permissions:
1313
contents: read
1414

1515
jobs:
16+
code-style-check:
17+
runs-on: ubuntu-latest
18+
timeout-minutes: 15
19+
steps:
20+
- name: "Checkout code"
21+
uses: actions/checkout@v4
22+
- name: "Use Node.js"
23+
uses: actions/setup-node@v4
24+
with:
25+
node-version: 23
26+
cache: "npm"
27+
- name: "Install dependencies"
28+
run: |
29+
npm run install-mm:dev
30+
- name: "Run linter tests"
31+
run: |
32+
npm run test:prettier
33+
npm run test:js
34+
npm run test:css
35+
npm run test:markdown
1636
test:
1737
runs-on: ubuntu-latest
1838
timeout-minutes: 30
@@ -36,8 +56,4 @@ jobs:
3656
Xvfb :99 -screen 0 1024x768x16 &
3757
export DISPLAY=:99
3858
touch css/custom.css
39-
npm run test:prettier
40-
npm run test:js
41-
npm run test:css
42-
npm run test:markdown
4359
npm run test

CHANGELOG.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,26 @@ _This release is scheduled to be released on 2025-01-01._
1616
- [core] Add wayland and windows start options to `package.json` (#3594)
1717
- [docs] Add step for npm publishing in release process (#3595)
1818
- [core] Add GitHub workflow to run spellcheck a few days before each release (#3623)
19-
- [core] Add test flag to index.html to pass to module js for test mode detection (needed by #3630)
19+
- [core] Add test flag to `index.html` to pass to module js for test mode detection (needed by #3630)
2020
- [core] Add export on animation names (#3644)
21-
- [compliments] add support for refreshing remote compliments file, and test cases (#3630)
21+
- [compliments] Add support for refreshing remote compliments file, and test cases (#3630)
2222
- [linter] Re-add `eslint-plugin-import`now that it supports ESLint v9 (#3586)
2323
- [linter] Re-activate `eslint-plugin-package-json` to lint `package.json` (#3643)
24-
- [linter] Add linting for markdown files.
24+
- [linter] Add linting for markdown files (#3646)
2525
- [calendar] - added ability to display end date for full date events, where end is not same day (showEnd=true)
2626

27+
### Changed
28+
29+
- [core] Run code style checks in workflow only once.
30+
2731
### Removed
2832

2933
- [tests] Remove `node-pty` and `drivelist` from rebuilded test (#3575)
3034
- [deps] Remove `@eslint/js` dependency. Already installed with `eslint` in deep (#3636)
3135

3236
### Updated
3337

34-
- [repo] reactivated `stale.yaml` as github action to mark issues as stale after 60 days and close them 7 days later (if no activity)
38+
- [repo] Reactivate `stale.yaml` as GitHub action to mark issues as stale after 60 days and close them 7 days later (if no activity) (#3577, #3580, #3581)
3539
- [core] Update electron dependency to v32 (test electron rebuild) and other dependencies too
3640
- [tests] All test configs have been updated to allow full external access, allowing for easier debugging (especially when running as a container)
3741
- [core] Run and test with node 23 (#3588)

0 commit comments

Comments
 (0)