Skip to content

Commit 979435c

Browse files
committed
add moduleConfig
1 parent 32c7672 commit 979435c

File tree

4 files changed

+29
-15
lines changed

4 files changed

+29
-15
lines changed

js/app.js

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -133,14 +133,17 @@ function App () {
133133
}
134134
checkDeprecatedOptions(c);
135135
var finalConfig = Object.assign(defaults, c);
136-
if (finalConfig.modules.length) {
136+
137+
/*
138+
if (finalConfig.modules.length) {
137139
for (const [index, module] of finalConfig.modules.entries()) {
138140
const moduleConfig = await loadModuleConfig(module);
139-
console.log("=> moduleConfig", moduleConfig, index, module.module);
140-
if (moduleConfig) finalConfig.modules[index].config = moduleConfig;
141+
if (moduleConfig) {
142+
finalConfig.modules[index].config = moduleConfig;
143+
}
141144
}
142145
}
143-
console.log("finalConfig --->", finalConfig);
146+
*/
144147
return finalConfig;
145148
} catch (e) {
146149
if (e.code === "ENOENT") {
@@ -254,31 +257,28 @@ function App () {
254257
Log.log("All module helpers loaded.");
255258
}
256259

260+
/*
257261
function loadModuleConfig (module) {
258-
console.log("[loadModuleConfig] module", module);
259-
260262
if (module.moduleConfig) {
261263
var moduleFolder = path.resolve(`${__dirname}/../modules/`, module.module);
262264
263265
if (defaultModules.includes(module.module)) {
264266
moduleFolder = path.resolve(`${__dirname}/../modules/default/`, module.module);
265267
}
266268
267-
268269
const moduleConfigFile = `${moduleFolder}/config/config.js`;
269270
console.log("[loadModuleConfig] moduleConfigFile", moduleConfigFile);
270271
try {
271272
fs.accessSync(moduleConfigFile, fs.R_OK);
272273
const configFile = require(moduleConfigFile);
273-
console.log("[loadModuleConfig] configFile", configFile);
274274
return configFile;
275275
} catch (e) {
276276
Log.error(`${moduleConfigFile} loading error for module: ${module.module}.`, e.message);
277277
return null;
278278
}
279279
}
280280
}
281-
281+
*/
282282
/**
283283
* Compare two semantic version numbers and return the difference.
284284
* @param {string} a Version number a.
@@ -311,7 +311,6 @@ function App () {
311311
*/
312312
this.start = async function () {
313313
config = await loadConfig();
314-
315314
Log.setLogLevel(config.logLevel);
316315

317316
// get the used module positions
@@ -321,10 +320,6 @@ function App () {
321320
for (const module of config.modules) {
322321
if (module.disabled) continue;
323322
if (module.module) {
324-
//const moduleConfig = await loadModuleConfig(module)
325-
//console.log("=> moduleConfig", moduleConfig)
326-
//if (moduleConfig) module.config = moduleConfig
327-
328323
if (Utils.moduleHasValidPosition(module.position) || typeof (module.position) === "undefined") {
329324
// Only add this module to be loaded if it is not a duplicate (repeated instance of the same module)
330325
if (!modules.includes(module.module)) {

js/loader.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ const Loader = (function () {
107107
hiddenOnStartup: moduleData.hiddenOnStartup,
108108
header: moduleData.header,
109109
configDeepMerge: typeof moduleData.configDeepMerge === "boolean" ? moduleData.configDeepMerge : false,
110+
moduleConfig: moduleData.moduleConfig,
110111
config: moduleData.config,
111112
classes: typeof moduleData.classes !== "undefined" ? `${moduleData.classes} ${module}` : module
112113
});
@@ -148,6 +149,10 @@ const Loader = (function () {
148149
* @param {Module} mObj Modules instance.
149150
*/
150151
const bootstrapModule = async function (module, mObj) {
152+
if (module.moduleConfig) {
153+
Log.log(`Init config for: ${module.name}`);
154+
await mObj.moduleConfig(module);
155+
}
151156
Log.info(`Bootstrapping module: ${module.name}`);
152157
mObj.setData(module);
153158

js/main.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,6 @@ const MM = (function () {
479479
}
480480

481481
config = Object.assign({}, defaults, config);
482-
console.log("config:", config);
483482
};
484483

485484
/**

js/module.js

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,21 @@ const Module = Class.extend({
226226
this.config = deep ? configMerge({}, this.defaults, config) : Object.assign({}, this.defaults, config);
227227
},
228228

229+
moduleConfig (module) {
230+
console.log("ok", module);
231+
return new Promise(function (resolve) {
232+
fetch(`${module.path}/config/config.js`)
233+
.then((response) => response.text())
234+
.then((txt) => {
235+
console.log("1--->", txt);
236+
const definedConfig = eval(txt);
237+
console.log("2---->", definedConfig);
238+
//module.config = json
239+
//resolve()
240+
});
241+
});
242+
},
243+
229244
/**
230245
* Returns a socket object. If it doesn't exist, it's created.
231246
* It also registers the notification callback.

0 commit comments

Comments
 (0)