Skip to content

Commit a5b85c4

Browse files
[workflow] Use LTS node version and split "Run test" step (#3767)
Two small changes to the workflows: - Run linter and spellcheck workflows with LTS node version. The advantage of this is that we no longer have to raise the node version for them. - Split "Run test" step into two steps for more clarity.
1 parent b9d63d7 commit a5b85c4

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

.github/workflows/automated-tests.yaml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- name: "Use Node.js"
2323
uses: actions/setup-node@v4
2424
with:
25-
node-version: 23
25+
node-version: lts/*
2626
cache: "npm"
2727
- name: "Install dependencies"
2828
run: |
@@ -55,13 +55,15 @@ jobs:
5555
- name: "Install MagicMirror²"
5656
run: |
5757
node --run install-mm:dev
58-
- name: "Run tests"
58+
- name: "Prepare environment for tests"
5959
run: |
6060
# Fix chrome-sandbox permissions:
6161
sudo chown root:root ./node_modules/electron/dist/chrome-sandbox
6262
sudo chmod 4755 ./node_modules/electron/dist/chrome-sandbox
6363
# Start labwc
6464
WLR_BACKENDS=headless WLR_LIBINPUT_NO_DEVICES=1 WLR_RENDERER=pixman labwc &
65-
export WAYLAND_DISPLAY=wayland-0
6665
touch css/custom.css
66+
- name: "Run tests"
67+
run: |
68+
export WAYLAND_DISPLAY=wayland-0
6769
node --run test

.github/workflows/spellcheck.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Set up Node.js
2222
uses: actions/setup-node@v4
2323
with:
24-
node-version: "22"
24+
node-version: lts/*
2525
check-latest: true
2626
cache: "npm"
2727
- name: Install dependencies

CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ planned for 2025-07-01
1818
### Changed
1919

2020
- [refactor] Simplify module loading process (#3766)
21-
- Use "node --run" instead of "npm run" (#1511)
21+
- Use "node --run" instead of "npm run" (#3764)
22+
- [workflow] Run linter und spellcheck with LTS node version (#3767)
23+
- [workflow] Split "Run test" step into two steps for more clarity (#3767)
2224

2325
## [2.31.0] - 2025-04-01
2426

0 commit comments

Comments
 (0)